[greybus-dev] Re: [PATCH v2] greybus/uart: Fix atomicity violation in get_serial_info()

On Wed, Nov 06, 2024 at 05:58:19PM +0800, Qiu-ji Chen wrote:

Our static checker found a bug where set_serial_info() uses a mutex, but get_serial_info() does not. Fortunately, the impact of this is relatively minor. It doesn't cause a crash or any other serious issues. However, if a race condition occurs between set_serial_info() and get_serial_info(), there is a chance that the data returned by get_serial_info() will be meaningless.

Signed-off-by: Qiu-ji Chen chenqiuji666@gmail.com Fixes: 0aad5ad563c8 ("greybus/uart: switch to ->[sg]et_serial()")

---

Thanks!

Reviewed-by: Dan Carpenter dan.carpenter@linaro.org

regards, dan carpenter