Re: [greybus-dev] [PATCH] staging: greybus: add blank line after declarations

On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote:

Fix CHECK: add blank line after declarations

Signed-off-by: Gabriela Bittencourt gabrielabittencourt00@gmail.com

drivers/staging/greybus/control.h | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h index 3a29ec05f631..5a45d55349a1 100644 --- a/drivers/staging/greybus/control.h +++ b/drivers/staging/greybus/control.h @@ -24,6 +24,7 @@ struct gb_control { char *vendor_string; char *product_string; };

#define to_gb_control(d) container_of(d, struct gb_control, dev)

No, the original code is "better" here, it's a common pattern despite what checkpatch.pl tells you, sorry.

thanks,

greg k-h