Hi Dan,
Thanks again—confirmed the structs are zero-initialized before the copy.
Would a minimal fix that guarantees NUL-termination be acceptable, e.g.:
strncpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE - 1); ((char *)&intf_load.firmware_tag)[GB_FIRMWARE_U_TAG_MAX_SIZE - 1] = '\0';
I can respin as v2 with the same change applied to the other two firmware_tag fields.
Best regards, Vivek
On 2025-10-14 10:15 a.m., Dan Carpenter wrote:
On Tue, Oct 14, 2025 at 10:01:28AM -0400, Vivek BalachandharTN wrote:
Yes, Dan. Nice catch. Building it with below sample change:
memset(&intf_load.firmware_tag, 0, GB_FIRMWARE_U_TAG_MAX_SIZE); strncpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE - 1);
There isn't a need to doing the memset()...
regards, dan carpenter