[greybus-dev] Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

Hi Uwe,

On Fri, Aug 04, 2023 at 04:27:06PM +0200, Uwe Kleine-König wrote:

Instead of requiring each driver to care for assigning the owner member of struct pwm_ops, handle that implicitly using a macro. Note that the owner member has to be moved to struct pwm_chip, as the ops structure usually lives in read-only memory and so cannot be modified.

The upside is that new lowlevel drivers cannot forget the assignment and save one line each. The pwm-crc driver didn't assign .owner, that's not a problem in practise though as the driver cannot be compiled as a

/practise/practice/

module.

Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de

Acked-by: Andi Shyti andi.shyti@kernel.org

Thanks, Andi