On 02/09/2023 20:28, Ayush Singh wrote:
Add DT bindings for BeagleCC1352 co-processor UART.
This does not look like UART controller.
The BeaglePlay has a CC1352 co-processor. This co-processor is connected to the main AM62 (running Linux) over UART. The CC1352 can run Zephyr and other embedded OS. This commit adds DT bindings for the BeagleCC1352
Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submit...
UART, which will allow Linux platform drivers to identify and access this device.
This commit adds serial/beaglecc1352 for identifying this UART. It is used by an upcoming gb-beagleplay greybus driver.
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
.../bindings/serial/beaglecc1352.yaml | 25 +++++++++++++++++++
It's not a serial driver. Don't put it in unrelated directory.
MAINTAINERS | 6 +++++ 2 files changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/serial/beaglecc1352.yaml
diff --git a/Documentation/devicetree/bindings/serial/beaglecc1352.yaml b/Documentation/devicetree/bindings/serial/beaglecc1352.yaml new file mode 100644 index 000000000000..54db630a2a50 --- /dev/null +++ b/Documentation/devicetree/bindings/serial/beaglecc1352.yaml
Missing vendor prefix. Filename should match compatible. Compatible is not "beaglecc1352"
@@ -0,0 +1,25 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/serial/beaglecc1352.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: BeaglePlay CC1352 serial UART
How is this serial UART? Of what? The SoC? Do not describe interface but the device.
+maintainers:
- Ayush Singh ayushdevel1325@gmail.com
+properties:
- compatible:
- const: beagle,cc1352
No resources? This does not seem useful... Put it then only in trivial devices if your hardware - hardware, not driver - does not have any pins, interrupts or other resources.
+required:
- compatible
+additionalProperties: false
+examples:
- |
- beaglecc1352 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre...
Best regards, Krzysztof