Re: [greybus-dev] [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()

Hi Chen Zhou, Thanks for the patch.

On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote:

In gb_lights_light_config(), 'light->name' is allocated by kstrndup(). It returns NULL when fails, add check for it.

Signed-off-by: Chen Zhou chenzhou10@huawei.com

Acked-by: Rui Miguel Silva rmfrfs@gmail.com

------ Cheers, Rui

---

drivers/staging/greybus/light.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index d6ba25f..d2672b6 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1026,7 +1026,8 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL);

• if (!light->name)

• return -ENOMEM;
  

  light->channels = kcalloc(light->channels_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels)

-- 2.7.4