[greybus-dev] Re: [PATCH] staging: greybus: fix possible null-ptr-deref in gb_audio_manager_get_module()

On Sat, Oct 26, 2024 at 08:11:53AM +0000, Yi Yang wrote:

The gb_audio_manager_get_module() is EXPORT_SYMBOL, and will return NULL when incoming parameter id < 0, fix possible null-ptr-deref by add check for return value.

Fixes: 8db00736d365 ("greybus: audio: Add Audio Manager") Signed-off-by: Yi Yang yiyang13@huawei.com

Where is gb_audio_manager_get_module() called from? So far as I can see it's never used. Why not just delete it?

regards, dan carpenter