Hi Alex, On Tue 27 Aug 2019 at 18:22, Alex Elder wrote:
On 8/27/19 10:53 AM, Rui Miguel Silva wrote:
Before moving greybus core out of staging and moving header files to include/linux some greybus header files were missing the necessary includes. This would trigger compilation faillures with some example errors logged bellow for with CONFIG_KERNEL_HEADER_TEST=y.
So, add the necessary headers to compile clean before relocating the header files.
This looks good to me; I trust you compiled it.
Yeah, in the staging and in the new location to make sure it make the compilation issues go away.
There is one extra blank line you added in "operation.h" but that's not important.
Right, I missed that.
I don't think what I've done here serves as a real review, so:
Acked-by: Alex Elder elder@kernel.org
I think Greg already queued up this one in staging-next, nevertheless many thanks for the acked.
--- Cheers, Rui