[greybus-dev] Re: [PATCH v2 1/2] [PATCH v2 1/2] staging: greybus: fw-management: Add detailed mutex comment

On Mon, Apr 28, 2025 at 09:38:36PM +0530, Sridhar Arra wrote:

Added a detailed comment explaining the role of the mutex in serializing firmware management ioctl() operations. The mutex prevents concurrent access to firmware operations and protects the 'disabled' state flag during disconnection.

Signed-off-by: Sridhar Arra sridhar.arra@yahoo.com

drivers/staging/greybus/fw-management.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)

diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index a47385175582..56725b711a17 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -28,6 +28,19 @@ struct fw_mgmt { /* Common id-map for interface and backend firmware requests */ struct ida id_map;

• /*

• * Mutex to serialize firmware management ioctl() operations and
  

• * protect against concurrent access.
  

• *
  

• * Ensures that user-space cannot perform multiple firmware
  

• * operations in parallel (e.g., updating interface firmware)
  

• * for the same Interface, avoiding race conditions and reducing
  

• * code complexity.
  

• *
  

• * Also protects the 'disabled' state flag, preventing new
  

• * operations from starting when the firmware management
  

• * connection is being disconnected.
  

• */
  

  struct mutex mutex; struct completion completion; struct cdev cdev;

-- 2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot