[greybus-dev] Re: [PATCH] staging: greybus: Refactor gb_audio_gb_get_topology() into separate calls

On Fri, Aug 04, 2023 at 03:31:34PM -0500, Madhumitha Prabakaran wrote:

Refactor gb_audio_gb_get_topology() into separate calls for better modularity.

This is too vague. Just say "There is a comment which says 'Split into separate calls' so I have done it." But actually, please just delete the comment instead. This code is already an endless series of wrappers around wrappers.

Also, please run your patch through scripts/checkpatch.pl.

Btw, I just want to emphasize again that I was 100% serious when I asked you to delete the comment.

regards, dan carpenter