On 02/10/2023 20:24, Ayush Singh wrote:
Add DT bindings for BeaglePlay CC1352 co-processor.
Thank you for your patch. There is something to discuss/improve.
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For example: dt-bindings: net:
The BeaglePlay has a CC1352 co-processor. This co-processor is connected to the main AM62 (running Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible for handling 6LoWPAN communication with beagleconnect freedom nodes as well as their discovery
This commit adds net/ti,cc1352p7. It is used by gb-beagleplay greybus
A nit: I pointed you to the documentation explaining not to use "This commit adds". It's v6 and the wording is back. Instead drop both sentences - they are pointless in this context. First one repeats previous text, second describes driver, but we do not talk here about drivers.
driver.
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
.../devicetree/bindings/net/ti,cc1352p7.yaml | 48 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml new file mode 100644 index 000000000000..57bc2c43e5b1 --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Texas Instruments Simplelink CC1352P7 wireless MCU
+description:
- The cc1352p7 mcu can be connected via SPI or UART.
If over SPI, then the binding is incomplete. This is fine for now, I guess.
+maintainers:
- Ayush Singh ayushdevel1325@gmail.com
+properties:
- compatible:
- const: ti,cc1352p7
- clocks:
- maxItems: 2
Instead please list the items like:
clocks: items: - description: High-Foo-bar - description: Low-Foo-bar
- reset-gpios:
- maxItems: 1
- power-gpios:
- maxItems: 3
- description:
The device has three power rails that are exposed on external pins VDDS,VDDR and DCOUPL.
No, power rails are not GPIOs. You need supplies, so: vdds-supply: true vddr-supply: true dcoupl-supply: true
Look also at: Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml which explicitly allows only one powerdown GPIO.
Best regards, Krzysztof