On Fri, Feb 18, 2022 at 10:22:28AM +0530, Ahamed Husni wrote:
Hi Greg,
On Fri, Feb 18, 2022 at 12:56 AM Greg KH gregkh@linuxfoundation.org wrote:
Did you try to build this change?
I am a newbie kernel dev and trying to understand how things work. I did not build this change by the time I sent you this, thinking this is just a style change. I should have tested the build. I am sorry.
You always have to build-test your changes, as you have found out.
Now I built the changes by setting the following configurations. CONFIG_GREYBUS CONFIG_STAGING CONFIG_GREYBUS_LOOPBACK
My change introduces the following error. '''' drivers/staging/greybus/loopback.c:166:2: error: expected identifier or ‘(’ before ‘do’ 166 | do { \ | ^~ '''' I could not fix or find the reason for this error. Please guide me in this regard.
There is nothing wrong with the original code here. Remember that checkpatch is a perl script that gives good advice, but it is not always correct. You must always manually check it based on your knowledge of the C language.
I recommend learning a bit more C before working on kernel code.
Best of luck!
greg k-h