On 13:51-20231005, Ayush Singh wrote:
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
.../devicetree/bindings/net/ti,cc1352p7.yaml | 51 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml new file mode 100644 index 000000000000..291ba34c389b --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Texas Instruments Simplelink CC1352P7 wireless MCU
+description:
- The cc1352p7 mcu can be connected via SPI or UART.
+maintainers:
- Ayush Singh ayushdevel1325@gmail.com
+properties:
- compatible:
- const: ti,cc1352p7
- clocks:
- maxItems: 2
- clock-names:
- description:
sclk_hf is the main system (mcu and peripherals) clocksclk_lf is low-frequency system clockThis does no go here, but to clocks. I wrote how it should be done. Don't ignore the feedback.
It was suggested to use `clock-names` by Nishanth Menon in the previous email, so I thought this was what it meant. I will remove clock-names if that's better.
Krzysztof was mentioning that the description should be with clocks. clock-names would allow for more descriptive dts
- items:
- const: sclk_hf- const: sclk_lf- reset-gpios: true
No, really, why do you change correct code into incorrect one? Who asked you to drop maxItems?
I found that many bindings (`display/ilitek,ili9486.yaml`, `iio/dac/adi,ad5758.yaml`) use this pattern instead of `maxItems` for `reset-gpios`. So I assumed it was some sort of convention. I will change it back to `maxItems`.
maxItems restrict the number of GPIOs to the ones that are actually needed for the peripheral.