On Tue, Jun 02, 2020 at 03:57:15PM +0300, Dan Carpenter wrote:
On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote:
Currently, GB codec and audio module is conditionally compiled based on GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 platform and can be used generically with any platform that follows GB Audio class specification.
Also, GB codec driver corresponds to dummy codec represented by I2S port available on Toshiba AP Bridge. Added config option for the same in kconfig file and accordingly updated Makefile.
This commit message was a bit confusing to me. Just say:
"Currently you can't enable the Grey Bus Audio Codec because there is no entry for it in the Kconfig file. Originally the config name was going to be AUDIO_MSM8994 but that's not correct because other types of hardware are supported now. I have chosen the name AUDIO_APB_CODEC instead. Also I had to update the dependencies for GREYBUS_AUDIO to make the compile work."
Otherwise this looks fine.
Thanks Dan for sharing your valuable feedback. I'll make the suggested changes for the complete series in v2 patchset.
regards, vaibhav
regards, dan carpenter