The USB bridged-PHY protocol has never been supported by the upstream USB core and cannot function. Remove the obsolete FIXME and keep the protocol disabled with a straightforward explanatory comment.
Signed-off-by: Ayaan Mirza Baig ayaanmirzabaig85@gmail.com --- drivers/staging/greybus/usb.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c index 1502641f5dbb..e1c9966ab678 100644 --- a/drivers/staging/greybus/usb.c +++ b/drivers/staging/greybus/usb.c @@ -194,23 +194,10 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, if (retval) goto exit_connection_destroy;
- /* - * FIXME: The USB bridged-PHY protocol driver depends on changes to - * USB core which are not yet upstream. - * - * Disable for now. - */ - if (1) { + /* The USB bridged-PHY protocol is not supported by upstream USB core */ dev_warn(dev, "USB protocol disabled\n"); retval = -EPROTONOSUPPORT; goto exit_connection_disable; - } - - retval = usb_add_hcd(hcd, 0, 0); - if (retval) - goto exit_connection_disable; - - return 0;
exit_connection_disable: gb_connection_disable(connection);