Re: [greybus-dev] [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

On Tue, Jan 17, 2017 at 11:22 PM, Mark Greer mgreer@animalcreek.com wrote:

On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:

...

From: Vaibhav Agarwal vaibhav.agarwal@linaro.org

Proper byte order was completely disregarded for multi byte data shared between AP and module (and APB1). Fix this.

Signed-off-by: Vaibhav Agarwal vaibhav.agarwal@linaro.org

Hi Vaibhav.

I think you got them all except for this one in audio_topology.c:gbcodec_mixer_dapm_ctl_put():

...

...

...

max = info->value.integer.max;  <<<

    mask = (1 << fls(max)) - 1;
    val = ucontrol->value.integer.value[0] & mask;
    connect = !!val;

Oh Ok. I'll include this change in v3.

-- vaibhav

Mark