On Mon, Dec 29, 2025 at 10:27:04PM -0800, Randy Dunlap wrote:
The Kconfig symbol USB_HSIC_USB3613 is not defined in the kernel source tree. Drop it since it unused.
Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver")
As the commit message of that commit says this was done on purpose to allow the driver to be compile tested without the out-of-tree driver that never went upstream.
These days we have a USB hub driver that should probably be used instead, but yeah, someone would need to do the rework.
And while referencing the commit is good, I'm not sure a Fixes tag is warranted.
Signed-off-by: Randy Dunlap rdunlap@infradead.org
--- linux-next-20251219.orig/drivers/staging/greybus/arche-platform.c +++ linux-next-20251219/drivers/staging/greybus/arche-platform.c @@ -23,14 +23,10 @@ #include <linux/of.h> #include "arche_platform.h" -#if IS_ENABLED(CONFIG_USB_HSIC_USB3613) -#include <linux/usb/usb3613.h> -#else static inline int usb3613_hub_mode_ctrl(bool unused) { return 0; } -#endif #define WD_COLDBOOT_PULSE_WIDTH_MS 30 --- linux-next-20251219.orig/drivers/staging/greybus/Kconfig +++ linux-next-20251219/drivers/staging/greybus/Kconfig @@ -206,7 +206,6 @@ endif # GREYBUS_BRIDGED_PHY config GREYBUS_ARCHE tristate "Greybus Arche Platform driver"
- depends on USB_HSIC_USB3613 || COMPILE_TEST help Select this option if you have an Arche device.
The above just seems to hide the fact that the driver currently cannot be used.
Can you please at least add some kind of TODO comment to indicate that the driver should be reworked to drop the dependency on the OOT driver?
And it's probably best to keep the depends on COMPILE_TEST until that has been resolved. Perhaps also wrap usb3613_hub_mode_ctrl() in
#ifdef CONFIG_COMPILE_TEST ... #endif
Johan