11 Jan
2019
11 Jan
'19
8:36 a.m.
On Thu, Jan 10, 2019 at 11:24:28PM +0530, Nishad Kamdar wrote:
Convert the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of reimplementing the same.
Signed-off-by: Nishad Kamdar nishadkamdar@gmail.com
Changes in v5:
- Restore "struct irq_chip irqc" in "struct gb_gpio_controller" This is because we cannot use the gpio-chip irqchip, as that will register the irqchip automatically and possibly in an incompatible way.
Changes in v4:
- Remove changes related to conversion to gpiochip_get_data() to include it as a new patch.
- Remove the 'struct irq_chip' field from 'struct gb_gpio_controller' as struct gpio_chip will have an irqchip whenever CONFIG_GPIOLIB_IRQCHIP is selected.
- Update the TODO file as per the changes.
Changes in v3:
- Combine patches as into a patch series.
Changes in v2:
- Retained irq.h and irqdomain.h headers.
- Dropped function gb_gpio_irqchip_add() and called gpiochip_irqchip_add() from probe().
- Referred https://lkml.kernel.org/r/1476054589-28422-1-git-send-email-linus.walleij@li....
Looks good to me now, thanks for sticking with it.
Reviewed-by: Johan Hovold johan@kernel.org
Johan