On Tue, Apr 12, 2022 at 10:28:43AM +0300, Dan Carpenter wrote:
On Mon, Apr 11, 2022 at 09:50:22PM -0400, Jaehee Park wrote:
Issue found by checkpatch: WARNING: void function return statements are not generally useful
Signed-off-by: Jaehee Park jhpark1013@gmail.com
drivers/staging/greybus/audio_codec.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 0f50d1e51e2c..3e3a16568def 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -1032,7 +1032,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) static void gbcodec_remove(struct snd_soc_component *comp) { /* Empty function for now */
- return;
}
This function is called from snd_soc_component_remove(). You can safely remove the whole function. We do not like empty stub functions.
I'll make this into another patch. Thank you for your suggestion.
regards, dan carpenter