[greybus-dev] Re: [PATCH v3 8/8] dts: ti: k3-am625-beagleplay: Add mikroBUS

On 15/03/2024 19:49, Ayush Singh wrote:

Add mikroBUS connector support for Beagleplay.

Signed-off-by: Ayush Singh ayushdevel1325@gmail.com

.../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 76 +++++++++++++++++-- 1 file changed, 68 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts index a34e0df2ab86..886308f99d1a 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts @@ -29,6 +29,7 @@ aliases { i2c3 = &main_i2c3; i2c4 = &wkup_i2c0; i2c5 = &mcu_i2c0;

• mikrobus0 = &mikrobus0;
  

  mmc0 = &sdhci0; mmc1 = &sdhci1; mmc2 = &sdhci2;

@@ -230,6 +231,33 @@ simple-audio-card,codec { }; };

• mikrobus0: linux-mikrobus {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre...

mikrobus {

• compatible = "mikrobus-connector";
  

• pinctrl-names = "default", "pwm_default", "pwm_gpio",
  

• 		"uart_default", "uart_gpio", "i2c_default",
  

• 		"i2c_gpio", "spi_default", "spi_gpio";
  

• pinctrl-0 = <&mikrobus_gpio_pins_default>;
  

• pinctrl-1 = <&mikrobus_pwm_pins_default>;
  

• pinctrl-2 = <&mikrobus_pwm_pins_gpio>;
  

• pinctrl-3 = <&mikrobus_uart_pins_default>;
  

• pinctrl-4 = <&mikrobus_uart_pins_gpio>;
  

• pinctrl-5 = <&mikrobus_i2c_pins_default>;
  

• pinctrl-6 = <&mikrobus_i2c_pins_gpio>;
  

• pinctrl-7 = <&mikrobus_spi_pins_default>;
  

• pinctrl-8 = <&mikrobus_spi_pins_gpio>;
  

• i2c-adapter = <&main_i2c3>;
  

• spi-controller = <&main_spi2>;
  

• spi-cs = <0 1>;
  

• uart = <&main_uart5>;
  

• pwms = <&ecap2 0 500000 0>;
  

• mikrobus-gpios =
  

• <&main_gpio1 11 GPIO_ACTIVE_HIGH>, <&main_gpio1 9 GPIO_ACTIVE_HIGH>,
  

Join with previous line.

• <&main_gpio1 24 GPIO_ACTIVE_HIGH>, <&main_gpio1 25 GPIO_ACTIVE_HIGH>,
  

Fix indentation. See DTS coding style.

• <&main_gpio1 22 GPIO_ACTIVE_HIGH>, <&main_gpio1 23 GPIO_ACTIVE_HIGH>,
  

• <&main_gpio1 7 GPIO_ACTIVE_HIGH>, <&main_gpio1 8 GPIO_ACTIVE_HIGH>,
  

• <&main_gpio1 14 GPIO_ACTIVE_HIGH>, <&main_gpio1 13 GPIO_ACTIVE_HIGH>,
  

• <&main_gpio1 12 GPIO_ACTIVE_HIGH>, <&main_gpio1 10 GPIO_ACTIVE_HIGH>;
  

• };

};

&main_spi2 {

• pinctrl-names = "default";
• pinctrl-0 = <&mikrobus_spi_pins_default>; status = "okay";

}; @@ -875,9 +932,8 @@ &main_uart1 { }; &main_uart5 {

• pinctrl-names = "default";
• pinctrl-0 = <&mikrobus_uart_pins_default>; status = "okay";

• force-empty-serdev-controller;

NAK. Don't add undocumented properties. That's a clear no go.

Best regards, Krzysztof