Re: [greybus-dev] [PATCH] Staging: greybus: Fix spinlock_t definition without comment

On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran wrote:

Fix spinlock_t definition without comment.

Signed-off-by: Madhumitha Prabakaran madhumithabiw@gmail.com

drivers/staging/greybus/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h index 5ca3befc0636..0aedd246e94a 100644 --- a/drivers/staging/greybus/connection.h +++ b/drivers/staging/greybus/connection.h @@ -47,7 +47,7 @@ struct gb_connection { unsigned long flags; struct mutex mutex;

• spinlock_t lock;

• spinlock_t lock; /* Protect structure fields */ enum gb_connection_state state;

What does the mutex do then? Why can't we just use the spinlock for everything?

I did glance at the code and it wasn't immediately obvious to me.

regards, dan carpenter