[greybus-dev] Re: [RFC 6/6] greybus: add class driver for Silabs Bluetooth

On Fri, Jul 04, 2025 at 08:40:36PM -0400, Damien Riégel wrote:

+#include <linux/greybus.h> +#include <linux/skbuff.h> +#include <net/bluetooth/bluetooth.h> +#include <net/bluetooth/hci_core.h>

+#define GREYBUS_VENDOR_SILABS 0xBEEF +#define GREYBUS_PRODUCT_EFX 0xCAFE

Nice vendor ids :)

We really should make a file for all of the current ones, to keep track of them. At the least, the vendor ids should be made unique.

Overall this looks very good, a clean and small driver. Would you have other ones for this type of transport layer?

thanks,

greg k-h