Hi, On Wed, Aug 09, 2017 at 02:15:54PM +0300, Sakari Ailus wrote:
The V4L2 flash interface allows controlling multiple LEDs through a single sub-devices if, and only if, these LEDs are of different types. This approach scales badly for flash controllers that drive multiple flash LEDs or for LED specific associations. Essentially, the original assumption of a LED driver chip that drives a single flash LED and an indicator LED is no longer valid.
Address the matter by registering one sub-device per LED.
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Reviewed-by: Jacek Anaszewski jacek.anaszewski@gmail.com Acked-by: Pavel Machek pavel@ucw.cz
drivers/leds/leds-aat1290.c | 4 +- drivers/leds/leds-max77693.c | 4 +- drivers/media/v4l2-core/v4l2-flash-led-class.c | 113 +++++++++++++++---------- drivers/staging/greybus/light.c | 23 +++--
For greybus/light: Reviewed-by: Rui Miguel Silva rmfrfs@gmail.com
--- Cheers, Rui