On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote:
Fix the warning reported by cocci check.
What is "cocci check"?
Changes:
Why add that line?
In queue_work fw dereference before it actually get assigned. move queue_work before gb_bootrom_set_timeout.
As gb_bootrom_get_firmware () return NEXT_REQ_READY_TO_BOOT only when there is no error and offset + size is actually equal to fw->size. So initialized next_request to NEXT_REQ_GET_FIRMWARE for return in other case.
Signed-off-by: Saurav Girepunje saurav.girepunje@gmail.com
drivers/staging/greybus/bootrom.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
As Johan said, there are a lot of really bad "static checking" tools out there that can not properly parse C code. Always verify by hand what the tools said is wrong, really is an issue before sending a patch out for something that is not correct. This looks like you need to use a better tool.
greg k-h