[greybus-dev] Re: [PATCH v2] staging: greybus: break multi statement macro into multiple lines

On Wed, Jul 17, 2024 at 10:32:07PM -0500, Juan José Arboleda wrote:

The macro `gb_loopback_stats_attrs` in the Greybus loopback driver contains multiple statements, which should be enclosed in a do-while loop to ensure proper execution and adhere to coding standards.

The latter is not possible as the macro expansion will create invalid C syntax. Theres is not such thing like inner function definition inside a global scope do-while in C.

This patch nukes the `gb_loopback_stats_attrs` macro to enclose, addressing the style error flagged by checkpatch.pl.

Signed-off-by: Juan José Arboleda soyjuanarbol@gmail.com

Sorry, it's not really important to follow checkpatch. Checkpatch is just a Perl script and sometimes it gets things wrong. It's a tool not a king.

regards, dan carpenter