Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error

On Sun, Mar 31, 2019 at 01:30:40AM -0400, Will Cunningham wrote:

Line was >80 characters.

Signed-off-by: Will Cunningham wjcunningham7@gmail.com

drivers/staging/greybus/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c index 1c246c73a085..5b4cbec88159 100644 --- a/drivers/staging/greybus/usb.c +++ b/drivers/staging/greybus/usb.c @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, return -ENOMEM; connection = gb_connection_create(gbphy_dev->bundle,

• 			  le16_to_cpu(gbphy_dev->cport_desc->id),
  

• 			  NULL);
  

• 		le16_to_cpu(gbphy_dev->cport_desc->id),
  

• 		NULL);
  

As others have already pointed out in this thread, there's no need to fix anything here.

The 80 column rule is not absolute in any way, and having a line be 81 characters if that improves readability is just fine.

Johan