[greybus-dev] Re: [RFC PATCH v2 10/12] greybus: cpc: use holding queue instead of sending out immediately

On Fri Nov 14, 2025 at 10:07 AM EST, Damien Riégel wrote:

+/* Write skbs at the head of holding queue */ +void __cpc_protocol_write_head(struct cpc_cport *cport)

I have a nitpick with the name of this function. I find it misleading, as it suggests we are writing to the CPort's holding queue head. Instead, we are processing the queue to send skbs that fit in the remote's RX window (that feature actually comes in another commit).

I propose we rename this API to something along the lines of `__cpc_protocol_send_holding_queue` and remove the comment above it.

Thanks,