This exports a new symbol, gb_hd_create_p2p, which let users create a host device that doesn't have an SVC. As other gb_hd_* functions already support handling a host device with a NULL 'svc' pointer, this is safe to expose.
Signed-off-by: Damien Riégel damien.riegel@silabs.com --- drivers/greybus/hd.c | 23 +++++++++++++++++++---- include/linux/greybus/hd.h | 4 ++++ 2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/drivers/greybus/hd.c b/drivers/greybus/hd.c index 1e2f1f3a65f..2fc9fbe987f 100644 --- a/drivers/greybus/hd.c +++ b/drivers/greybus/hd.c @@ -132,10 +132,10 @@ const struct device_type greybus_hd_type = { .release = gb_hd_release, };
-struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver, - struct device *parent, - size_t buffer_size_max, - size_t num_cports) +struct gb_host_device *gb_hd_create_p2p(struct gb_hd_driver *driver, + struct device *parent, + size_t buffer_size_max, + size_t num_cports) { struct gb_host_device *hd; int ret; @@ -197,6 +197,21 @@ struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver,
trace_gb_hd_create(hd);
+ return hd; +} +EXPORT_SYMBOL_GPL(gb_hd_create_p2p); + +struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver, + struct device *parent, + size_t buffer_size_max, + size_t num_cports) +{ + struct gb_host_device *hd; + + hd = gb_hd_create_p2p(driver, parent, buffer_size_max, num_cports); + if (IS_ERR(hd)) + return hd; + hd->svc = gb_svc_create(hd); if (!hd->svc) { dev_err(&hd->dev, "failed to create svc\n"); diff --git a/include/linux/greybus/hd.h b/include/linux/greybus/hd.h index 718e2857054..28ee7fca1d1 100644 --- a/include/linux/greybus/hd.h +++ b/include/linux/greybus/hd.h @@ -72,6 +72,10 @@ struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver, struct device *parent, size_t buffer_size_max, size_t num_cports); +struct gb_host_device *gb_hd_create_p2p(struct gb_hd_driver *driver, + struct device *parent, + size_t buffer_size_max, + size_t num_cports); int gb_hd_add(struct gb_host_device *hd); void gb_hd_del(struct gb_host_device *hd); void gb_hd_shutdown(struct gb_host_device *hd);