11 Feb
2021
11 Feb
'21
10:10 a.m.
On 11-02-21, 11:00, Greg KH wrote:
On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
This patch add fixes an checkpatch error for "Macros with multiple statements should be enclosed in a do - while loop"
Signed-off-by: Hemansh Agnihotri hemanshagnihotri27@gmail.com
Any reason you didn't test-build your patch before sending it out?
That's a bit rude to reviewers :(
I also wonder how two people stumbled upon the exact same thing at the same time. Copy/paste ?
https://lore.kernel.org/lkml/20210210221439.3489-2-yildirim.fatih@gmail.com/
And of course NAK for the patch. The macro is used outside of any other routine, and is actually used to create routines. No do-while required here.
--
viresh