On Tue, Jan 17, 2017 at 11:04 PM, Mark Greer mgreer@animalcreek.com wrote:
On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote:
From: Vaibhav Agarwal vaibhav.agarwal@linaro.org
Dummy codec register were initially added while populating dummy codec mixer controls until module topology parser was available. Now, these dummy registers are nowhere used and thus can be safely removed.
Since ASoC framework requires a valid callback for both read & write register APIS, currently empty placeholders are kept to avoid panic.
Later, register mapping logic can be defined:
- Assuming fixed number of maximum modules connected and register bits
corresponds to basic info of each module OR 2. With a logic to dynamically grow register_cache_size based on codec modules added/removed.
Signed-off-by: Vaibhav Agarwal vaibhav.agarwal@linaro.org
drivers/staging/greybus/audio_codec.c | 39 ++--------------------------------- 1 file changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b9d66278ff87..30941f9e380d 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -1026,47 +1026,16 @@ static int gbcodec_remove(struct snd_soc_codec *codec) return 0; }
-static u8 gbcodec_reg[GBCODEC_REG_COUNT] = {
[GBCODEC_CTL_REG] = GBCODEC_CTL_REG_DEFAULT,[GBCODEC_MUTE_REG] = GBCODEC_MUTE_REG_DEFAULT,[GBCODEC_PB_LVOL_REG] = GBCODEC_PB_VOL_REG_DEFAULT,[GBCODEC_PB_RVOL_REG] = GBCODEC_PB_VOL_REG_DEFAULT,[GBCODEC_CAP_LVOL_REG] = GBCODEC_CAP_VOL_REG_DEFAULT,[GBCODEC_CAP_RVOL_REG] = GBCODEC_CAP_VOL_REG_DEFAULT,[GBCODEC_APB1_MUX_REG] = GBCODEC_APB1_MUX_REG_DEFAULT,[GBCODEC_APB2_MUX_REG] = GBCODEC_APB2_MUX_REG_DEFAULT,-};
gbcodec_reg_defaults[] and the definitions of 'GBCODEC_CTL_REG_DEFAULT', etc. can be removed now too, can't they?
Of course, this should be removed as well. Nice catch. Thanks :)
-- vaibhav
The rest looks good.
Mark