Re: [greybus-dev] [PATCH 2/2] staging: greybus: audio: apbridgea: Fix reference counter leak in error handling

On Mon, Nov 09, 2020 at 09:13:47PM +0800, Zhang Qilong wrote:

When gb_audio_apbridgea_register_cport failed, maybe:

1. gb_pm_runtime_get_sync failed, usage counter remained unchanged;

2. gb_hd_output failed, usage counter remained increased;

In error state, there are two different states in usage cpounter. So, if gb_hd_output failed, we should call gb_pm_runtime_put_autosuspend ot decrease usage counter for balabce preventing reference leak. And we fixed it by add gb_pm_runtime_put_autosuspend when gb_hd_output failed.

Fixes: 6ba7fad430d63 ("Add runtime pm support to audio protocol device class driver.")

That is not the name for that git commit id :(

Please fix up and resend.

thanks,

greg k-h