[greybus-dev] Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352

On 23:54-20231002, Ayush Singh wrote:

Add DT bindings for BeaglePlay CC1352 co-processor.

The BeaglePlay has a CC1352 co-processor. This co-processor is connected to the main AM62 (running Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible for handling 6LoWPAN communication with beagleconnect freedom nodes as well as their discovery

This commit adds net/ti,cc1352p7. It is used by gb-beagleplay greybus driver.

Signed-off-by: Ayush Singh ayushdevel1325@gmail.com

.../devicetree/bindings/net/ti,cc1352p7.yaml | 48 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml

diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml new file mode 100644 index 000000000000..57bc2c43e5b1 --- /dev/null +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Texas Instruments Simplelink CC1352P7 wireless MCU

+description:

• The cc1352p7 mcu can be connected via SPI or UART.

+maintainers:

• • Ayush Singh ayushdevel1325@gmail.com

+properties:

• compatible:
• const: ti,cc1352p7
• clocks:
• maxItems: 2

I would suggest clock-names and description for it.

• reset-gpios:
• maxItems: 1
• power-gpios:
• maxItems: 3
• description:

•  The device has three power rails that are exposed on external pins VDDS,
  

•  VDDR and DCOUPL.
  

Shouldn't these be regulators? The power rails are input to the MCU, correct? The properties should be something like: vdds-supply vddr-supply dcoupl-supply ? (not sure what dcoupl is, but description should provide that info).

the gpio controls for those can be modelled by regulator-gpio ?

+required:

• • compatible

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• serial {

•  mcu {
  

•    compatible = "ti,cc1352p7";
  

•    clocks = <&sclk_hf 0>, <&sclk_lf 25>;
  

•    reset-gpios = <&pio 35 GPIO_ACTIVE_LOW>;
  

•    power-gpios = <&pio 1 GPIO_ACTIVE_HIGH>, <&pio 2 GPIO_ACTIVE_HIGH>, <&pio 3 GPIO_ACTIVE_HIGH>;
  

•  };
  

• };

diff --git a/MAINTAINERS b/MAINTAINERS index 37b9626ee654..5467669d7963 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8969,6 +8969,12 @@ F: drivers/staging/greybus/sdio.c F: drivers/staging/greybus/spi.c F: drivers/staging/greybus/spilib.c +GREYBUS BEAGLEPLAY DRIVERS +M: Ayush Singh ayushdevel1325@gmail.com +L: greybus-dev@lists.linaro.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/net/ti,cc1352p7.yaml

GREYBUS SUBSYSTEM M: Johan Hovold johan@kernel.org M: Alex Elder elder@kernel.org -- 2.41.0