[greybus-dev] Re: [PATCH v4] Replace all strncpy() calls with strscpy() and fix indentation issues.

On Sun, Nov 23, 2025 at 05:45:27AM +0000, Dharanitharan R wrote:

The firmware_tag string comes from userspace and may not be NUL terminated. strlcpy() performs strlen() on the source buffer, which can read past the end and potentially cause an Oops.

There is no "oops" in userspace.

strscpy() avoids this and guarantees NUL termination without overflowing the destination.

"NULL"

Also, what happened to the subject line prefix?

And finally, when you say "and", that means you should have multiple patches, do not do different things in the same patch, this should be 2. You also do not mention the coding style change in the body of the changlog :(

thanks,

greg k-h