[greybus-dev] Re: [PATCH v3 2/8] w1: Add w1_find_master_device

On Sat, Mar 16, 2024 at 12:19:00AM +0530, Ayush Singh wrote:

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index afb1cc4606c5..ce8a3f93f2ef 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -673,9 +673,9 @@ static int __w1_attach_slave_device(struct w1_slave *sl) sl->dev.of_node = of_find_matching_node(sl->master->dev.of_node, sl->family->of_match_table);

• dev_set_name(&sl->dev, "%02x-%012llx",

•  (unsigned int) sl->reg_num.family,
  

•  (unsigned long long) sl->reg_num.id);
  

• dev_set_name(&sl->dev, "%s-%02x-%012llx", sl->master->name,

•      (unsigned int)sl->reg_num.family,
  

•      (unsigned long long)sl->reg_num.id);
  

This is a user visible change likely to cause breakage. I know that I've written programmes for reading the DS18B20 temperature probes that depend on the sysfs device name remaining stable. The same is likely true of other program authors.