A historical FIXME indicated that this autosuspend call could be removed once the S2 Loader supported runtime PM. That hardware is no longer supported and Greybus runtime PM is stable as-is, so the FIXME is obsolete. Remove it and replace it with a descriptive comment.
Signed-off-by: Ayaan Mirza Baig ayaanmirzabaig85@gmail.com --- drivers/staging/greybus/fw-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 0fb15a60412f..b9e989a99f06 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -208,7 +208,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
greybus_set_drvdata(bundle, fw_core);
- /* FIXME: Remove this after S2 Loader gets runtime PM support */ + /* Drop runtime PM reference unless the interface disables PM */ if (!(bundle->intf->quirks & GB_INTERFACE_QUIRK_NO_PM)) gb_pm_runtime_put_autosuspend(bundle);
@@ -233,7 +233,7 @@ static void gb_fw_core_disconnect(struct gb_bundle *bundle) struct gb_fw_core *fw_core = greybus_get_drvdata(bundle); int ret;
- /* FIXME: Remove this after S2 Loader gets runtime PM support */ + /* Get runtime PM reference unless interface disables PM */ if (!(bundle->intf->quirks & GB_INTERFACE_QUIRK_NO_PM)) { ret = gb_pm_runtime_get_sync(bundle); if (ret)