On Tue, Apr 12, 2022 at 09:04:08AM +0200, Julia Lawall wrote:
On Mon, 11 Apr 2022, Jaehee Park wrote:
Issue found by checkpatch: WARNING: void function return statements are not generally useful
Even for a simple change, it wouldbe better to follow the model that the subject line should concisely orient the reader (eg "remove unneeded return") and the log message should give a more complete description. Simply repeating what checkpatch tells you is rarely a good idea. It says what the problem is in a general way, whereas you should be explaining the reasoning behind your fix in a specific case. Here you could say that an empty function with void return type does not need an explicit return, and that the problem was detected with checkpatch.
julia
Thank you for your edits. I've submitted version 2 of the patchset just now.
Signed-off-by: Jaehee Park jhpark1013@gmail.com
drivers/staging/greybus/audio_codec.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 0f50d1e51e2c..3e3a16568def 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -1032,7 +1032,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) static void gbcodec_remove(struct snd_soc_component *comp) { /* Empty function for now */
- return;
}
static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg,
2.25.1