On Fri, Jan 26, 2024 at 08:46:15AM -0600, Alex Elder wrote:
On 1/25/24 6:09 AM, Uwe Kleine-König wrote:
struct pwm_chip::dev is about to change. To not have to touch this driver in the same commit as struct pwm_chip::dev, use the macro provided for exactly this purpose.
Acked-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
I think I'd rather see the footprint of your change be much smaller than it is. Please see below.
You have noticed already yourself while reviewing a later patch touching this driver. But to be explicit here: Later it's not trivial any more to get the pwm_chip from a gb_pwm_chip. So I changed some functions to take a pwm_chip. This should be mentioned in the commit log though. I will improve that in the next iteration, and maybe split the introduction of pwmchip_parent() and the parameter changes in two changes.
Best regards Uwe