[Moving to lava-users as suggested by Neil]
On 11/07/2016 03:20 PM, Neil Williams (Code Review) wrote:
Neil Williams has posted comments on this change.
Change subject: Add support for the depthcharge bootloader ......................................................................
Patch Set 3:
(1 comment)
https://review.linaro.org/#/c/15203/3/lava_dispatcher/pipeline/actions/deplo...
File lava_dispatcher/pipeline/actions/deploy/tftp.py:
Line 127: def _ensure_device_dir(self, device_dir):
Cannot say that I have fully understood it yet. Would it be correct if the
The Strategy classes must not set or modify anything. The accepts method does some very fast checks and returns True or False. Anything which the pipeline actions need to know must be specified in the job submission or the device configuration. So either this is restricted to specific device-types (so a setting goes into the template) or it has to be set for every job using this method (for situations where the support can be used or not used on the same hardware for different jobs).
What is this per-device directory anyway and how is it meant to work with tftpd-hpa which does not support configuration modification without restarting itself? Jobs cannot require that daemons restart - other jobs could easily be using that daemon at the same time.
So each firmware image containing Depthcharge will also contain hardcoded values for the IP of the TFTP server, and for the paths of a cmdline.txt file and a FIT image. The FIT image containing a kernel and a DTB file, and optionally a ramdisk.
Because the paths are set when the FW image is flashed, we cannot use the per-job directory. Thus we add a parameter to the device that is to be set in the device-specific template of Chrome devices. If that parameter is present, then a directory in the root of the TFTP files tree will be created with the value of that parameter.
The TFTP server doesn't need to be restarted because its configuration is left unchanged, we just create a directory where depthcharge will look for the files.
Thanks,
Tomeu
I think this needs to move from IRC and gerrit to a thread on the lava-users mailing list where the principles can be checked through more easily.