Linaro-uefi

linaro-uefi@lists.linaro.org

811 discussions

[PATCH] arm64: Fix the bug in fdt module

by fu.wei＠linaro.org

From: Fu Wei <fu.wei(a)linaro.org> This patch goes with commit: 4d0cb755387d6f109b901386ed4d3d475df239fe arm64: Move FDT functions to separate module linux and xen_boot modules can't work without this patch. Signed-off-by: Fu Wei <fu.wei(a)linaro.org> --- grub-core/Makefile.core.def | 1 + grub-core/loader/arm64/fdt.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 2ef10d1..3ea4e49 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -1674,6 +1674,7 @@ module = { module = { name = fdt; arm64 = loader/arm64/fdt.c; + fdt = lib/fdt.c; enable = arm64; }; diff --git a/grub-core/loader/arm64/fdt.c b/grub-core/loader/arm64/fdt.c index 5202c14..d160ca0 100644 --- a/grub-core/loader/arm64/fdt.c +++ b/grub-core/loader/arm64/fdt.c @@ -25,6 +25,10 @@ #include <grub/file.h> #include <grub/efi/efi.h> +GRUB_MOD_LICENSE ("GPLv3+"); + +static grub_dl_t my_mod; + static void *loaded_fdt; static void *fdt; @@ -177,6 +181,7 @@ GRUB_MOD_INIT (fdt) cmd_devicetree = grub_register_command ("devicetree", grub_cmd_devicetree, 0, N_("Load DTB file.")); + my_mod = mod; } GRUB_MOD_FINI (fdt) -- 2.4.3

9 years, 2 months

[PATCH] MdePkg/BaseSynchronizationLib: fix return value

by Haojian Zhuang

Fix the wrong return value of both InternalSyncIncrement() and InternalSyncDecrement(). The return value shouldn't be the address of input parameter. It should be the updated value of input parameter instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhuang(a)linaro.org> --- MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S b/MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S index ecb87fc..830ea5b 100644 --- a/MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S +++ b/MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S @@ -171,6 +171,7 @@ TryInternalSyncIncrement: add w1, w1, #1 stxr w2, w1, [x0] cbnz w2, TryInternalSyncIncrement + mov x0, x1 dmb sy ret @@ -199,5 +200,6 @@ TryInternalSyncDecrement: sub w1, w1, #1 stxr w2, w1, [x0] cbnz w2, TryInternalSyncDecrement + mov x0, x1 dmb sy ret -- 1.9.1

9 years, 2 months

[RFC] Adaptively change serial terminal polling interval

by Heyi Guo

Hi folks, In MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf, the polling interval is fixed by macro: #define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s However, this may cause fast input truncation on some platform. For example, we have a serial console with below features: 1. Baud rate: 115200 2. FIFO depth of UART device: 32 If we want to capture all input, we need to poll with the interval of 32 / (115200 / (8 + 1 + 1)) = 2.8 ms, 8 + 1 + 1 for data bits + start bit + stop bit. So, I suppose to use a PCD to set the interval statically, or calculate from serial IO protocol IO Mode data dynamically, which contains FIFO depth and data bits, etc. Please let me know your comments. Thanks. (If you see my another mail like this, please ignore that; this one is the final version; sorry for the noise)

9 years, 3 months

[RFC] Add new interfaces to allocate memory with limited address in UncachedAllocationLib

by Heyi Guo

Hi folks, How about adding new interfaces to allocate memory with limited address in UncachedAllocationLib, something like AllocateMaxAddress of EFI_ALLOCATE_TYPE? The background is that we may still have legacy devices on ARM64 which requires 32bit memory for DMA transaction. Please let me know your comments. Thanks.

9 years, 3 months

[RFC] Adaptively polling serial terminal polling interal

by Heyi Guo

Hi folks, In MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf, the polling interval is fixed by macro: #define KEYBOARD_TIMER_INTERVAL 200000 // 0.02s However, this may cause fast input truncation on some platform. For example, we have a serial console with below features: 1. Baud rate: 115200 2. FIFO depth of UART device: 32 If we want to capture all input, we need to poll with the interval of 32 / (115200 / (8 + 1 + 1)) = 2.8 ms, 8 + 1 + 1 for data bits, start bit and stop bit. So, I suppose to use a PCD to set the interval statically, or calculate from serial IO protocol IO Mode data dynamically. Please let me know your comments. Thanks.

9 years, 3 months

[PATCH] VExpress ACPI MADT Fix

by Graeme Gregory

Correct Revision to the standard defined 3 rather than the erroneous 4 Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- Platforms/ARM/VExpress/AcpiTables/rtsm_ve-aemv8a/apic.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platforms/ARM/VExpress/AcpiTables/rtsm_ve-aemv8a/apic.asl b/Platforms/ARM/VExpress/AcpiTables/rtsm_ve-aemv8a/apic.asl index f94686e..27c77b5 100644 --- a/Platforms/ARM/VExpress/AcpiTables/rtsm_ve-aemv8a/apic.asl +++ b/Platforms/ARM/VExpress/AcpiTables/rtsm_ve-aemv8a/apic.asl @@ -36,7 +36,7 @@ [0004] Signature : "APIC" [0004] Table Length : 00000000 -[0001] Revision : 04 +[0001] Revision : 03 [0001] Checksum : 00 [0006] Oem ID : "LINARO" [0008] Oem Table ID : "RTSMVEV8" -- 2.4.3

9 years, 4 months

[edk2] [PATCH] ArmPlatformPkg: Bds: delete BootNext when fail

by Haojian Zhuang

If Bds launches BootNext with failure, delete it. Otherwise, we'll create BootNext variable by BdsStartOption() & delete it in BdsEntry() for each boot. It doesn't make sense to update this variable in non-volatile variable area for each boot. And the non-volatile variable area may be full of this message until overflow. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhuang(a)linaro.org> --- ArmPlatformPkg/Bds/Bds.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ArmPlatformPkg/Bds/Bds.c b/ArmPlatformPkg/Bds/Bds.c index ffae4bc..512e8e1 100644 --- a/ArmPlatformPkg/Bds/Bds.c +++ b/ArmPlatformPkg/Bds/Bds.c @@ -530,12 +530,12 @@ BdsEntry ( // BootNext has not been succeeded launched if (EFI_ERROR(Status)) { Print(L"Fail to start BootNext.\n"); - } - // Delete the BootNext environment variable - gRT->SetVariable (L"BootNext", &gEfiGlobalVariableGuid, - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, - 0, NULL); + // Delete the BootNext environment variable + gRT->SetVariable (L"BootNext", &gEfiGlobalVariableGuid, + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, + 0, NULL); + } } // Clear BootCurrent variable -- 2.1.4

9 years, 5 months

[edk2] [PATCH v3 0/3] support multiple PL061 gpio controllers

by Haojian Zhuang

*** BLURB HERE *** Changelog: v3: * Remove GPIO_PIN_MASK_HIGH_8BIT() and GPIO_PIN_MASK_LOW_8BIT(). * Avoid to use MmioAnd8() on updating GPIO DATA register, since PL061 could access each bit by specified register offset. * Add PLATFORM_GPIO_CONTROLLER structure in embedded gpio. * Support multiple PL061 gpio controllers in one platform. v2: * Append the patch to fix gpio pin mask macro. Haojian Zhuang (3): ArmPlatformPkg: PL061: fix accessing GPIO DATA EmbeddedPkg: enhance for multiple gpio controllers ArmPlatformPkg: PL061: support multiple controller ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 107 ++++++++++++++------- .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 +- ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 44 ++++----- EmbeddedPkg/EmbeddedPkg.dec | 1 + EmbeddedPkg/Include/Protocol/EmbeddedGpio.h | 18 ++++ 5 files changed, 115 insertions(+), 58 deletions(-) -- 2.1.4

9 years, 5 months

[PATCH] BaseTools GCC: remove GCC 4.6 support for ARM

by Ard Biesheuvel

FYI I am adding the below patch to my GCC consolidation series. -------------8<--------------- In GCC 4.7, a feature was added to the ARM backend that allows unaligned loads and stores to be emitted. Since it is enabled by default on ARMv6 and later CPUs, and since such code is not suitable in our case (i.e., bare metal code), we must disable it by passing the -mno-unaligned-access option if we are using GCC 4.7 or later. However, this particular feature and its enabling by default have been backported to version 4.6 by Linaro. Since the Linaro toolchains are widely used for ARM development, and also shipped by distros such as Ubuntu, we should disable the feature on version 4.6 as well. Unfortunately, since the upstream version does not support the feature, it also does not understand the -mno-unaligned-access option. Considering the above, and the fact that the oldest supported toolchain for AARCH64 is 4.7 as well, let's just drop support for 4.6 altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- BaseTools/Conf/tools_def.template | 30 -------------------- 1 file changed, 30 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index fabfe7436167..5707aafec8cd 100644 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -4160,36 +4160,6 @@ DEFINE GCC_AARCH64_RC_FLAGS = -I binary -O elf64-littleaarch64 -B aarch64 *_GCC46_X64_OBJCOPY_FLAGS = *_GCC46_X64_NASM_FLAGS = -f elf64 -################## -# GCC46 ARM definitions -################## -*_GCC46_ARM_OBJCOPY_PATH = echo -*_GCC46_ARM_CC_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_SLINK_PATH = ENV(GCC46_ARM_PREFIX)ar -*_GCC46_ARM_DLINK_PATH = ENV(GCC46_ARM_PREFIX)ld -*_GCC46_ARM_ASLDLINK_PATH = ENV(GCC46_ARM_PREFIX)ld -*_GCC46_ARM_ASM_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_PP_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_VFRPP_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_ASLCC_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_ASLPP_PATH = ENV(GCC46_ARM_PREFIX)gcc -*_GCC46_ARM_RC_PATH = ENV(GCC46_ARM_PREFIX)objcopy - -*_GCC46_ARM_ARCHCC_FLAGS = -*_GCC46_ARM_PLATFORM_FLAGS = -march=armv7-a - -*_GCC46_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -*_GCC46_ARM_ASLDLINK_FLAGS = DEF(GCC_ARM_ASLDLINK_FLAGS) -*_GCC46_ARM_ASM_FLAGS = DEF(GCC_ARM_ASM_FLAGS) -*_GCC46_ARM_DLINK_FLAGS = DEF(GCC_ARM_DLINK_FLAGS) -*_GCC46_ARM_PLATFORM_FLAGS = -march=armv7-a -*_GCC46_ARM_PP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(GCC_PP_FLAGS) -*_GCC46_ARM_RC_FLAGS = DEF(GCC_ARM_RC_FLAGS) -*_GCC46_ARM_VFRPP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(GCC_VFRPP_FLAGS) - - DEBUG_GCC46_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) -O0 -RELEASE_GCC46_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) - #################################################################################### # # GCC 4.7 - This configuration is used to compile under Linux to produce -- 1.9.1

9 years, 5 months

[edk2] [PATCH v2 0/2] fix PL061 gpio driver

by Haojian Zhuang

Changelog: v2: * Append the patch to fix gpio pin mask macro. Haojian Zhuang (2): ArmPlatformPkg: PL061: fix gpio pin mask macro ArmPlatformPkg: PL061: fix accessing gpio value ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.1.4

9 years, 5 months

← Newer
1
...
53
54
55
56
57
58
59
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi