Linaro-uefi

linaro-uefi@lists.linaro.org

811 discussions

[RFC] Use commit id as default FIRMWARE_VER

by Ryan Harkin

Hello UEFI builders! I'd like your feedback on this patch. I often look at boot logs from LAVA and other people and don't quite know where the UEFI binary came from. With ones that I've provided, I can often recognise the build date stamp. But at other times, I'm simply trying to work out if someone is building the code they say they are, or some other code. As the commit message says, rather than leaving the version string blank, my patch will append the git commit id of the current commit, with "dirty" appended if the user is building with uncommited mods. I considered including the code from linux scripts/setlocalversion, but apart from giving me a "-" at the front, I thought it was overkill. Comments? Cheers, Ryan. -- >From af952a40005536215cedbbeea9102915e461486f Mon Sep 17 00:00:00 2001 From: Ryan Harkin <ryan.harkin(a)linaro.org> Date: Tue, 30 Jun 2015 15:10:56 +0100 Subject: [PATCH] Use commit id as default FIRMWARE_VER If a FIRMWARE_VER setting is not provided and we are building from a GIT repo, provide a default value based on the SHA ID of the commit where we built from. If the repo has local uncommited changes, then we mark the version string with "-dirty". This is based loosely on the same idea from the linux kernel in: scripts/setlocalversion Signed-off-by: Ryan Harkin <ryan.harkin(a)linaro.org> --- uefi-build.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/uefi-build.sh b/uefi-build.sh index 486cf86..60ea872 100755 --- a/uefi-build.sh +++ b/uefi-build.sh @@ -27,6 +27,16 @@ function build_platform PLATFORM_DSC="`$TOOLS_DIR/parse-platforms.py $PLATFORM_CONFIG -p $board get -o dsc`" PLATFORM_ARCH="`$TOOLS_DIR/parse-platforms.py $PLATFORM_CONFIG -p $board get -o arch`" + if [[ $PLATFORM_BUILDFLAGS != *"FIRMWARE_VER"* ]]; then + if test -d .git && head=`git rev-parse --verify --short HEAD 2>/dev/null`; then + FIRMWARE_VER=`git rev-parse --short HEAD` + if ! git diff-index --quiet HEAD --; then + FIRMWARE_VER="${FIRMWARE_VER}-dirty" + fi + PLATFORM_BUILDFLAGS="$PLATFORM_BUILDFLAGS -D FIRMWARE_VER=$FIRMWARE_VER" + fi + fi + set_cross_compile CROSS_COMPILE="$TEMP_CROSS_COMPILE" -- 2.1.0

9 years, 11 months

ArmPlatformPkg: TC2 reset/shutdown broken in Tianocore EDK2 tree

by Ryan Harkin

The following 3 patches break reboot/shutdown from within UEFI on TC2 and probably all 32-bit ARM Ltd platforms: ee171cc 2015-05-08 ArmVExpressPkg: restrict ArmVExpressSysConfigLib to SEC and DXE_DRIVER [Ard Biesheuvel] c889bf2 2015-05-08 ArmVExpressPkg: avoid the use of ArmVExpressSysConfigLib at runtime [Ard Biesheuvel] 7b99da9 2015-05-08 ArmVExpressPkg: use PSCI for system reset at runtime [Ard Biesheuvel] The symptoms are that the board hangs when I try to call reboot/shutdown. If I revert the top two patches only (ee171cc and c889bf2), then the board crashes and continuously spews out the following message: Undefined OpCode Exception PC at 0xBF419DBC CPSR 0x800001D6 Reverting all three gets reboot/shutdown working again. Patch 7b99da9 is adding PSCI support to all ARM Ltd platforms. PSCI is a 64-bit only feature. Regards, Ryan.

9 years, 12 months

No console output with qemu and serial over telnet

by Roy Franz

I'm seeing some strange behavior when using the "-serial telnet:localhost:5000,server" option for serial output on qemu. I've been been using this for quite some time without problem, but recently I have been seeing a complete lack of output in about 1 in 5 times. At first I thought that it was just hung, but from looking at it with gdb it appears to be booting all the way to the shell. (I get the same backtrace with or without output.) I've tried a couple of different versions of qemu (2.2 and 2.3), and various versions of EDK2 and see the same behavior. Has anyone else seen something like this? Roy

10 years

Re: [Linaro-uefi] edk2[16933] EmbeddedPkg : Add FdtPlatformDxe driver

by Ryan Harkin

TC2 does not boot with this patch. After I reverted a previous patch that prevented TC2 from booting [1], I was left with a TC2 hanging with the following error: add-symbol-file /linaro/working/edk2.git/Build/ArmVExpress-CTA15-A7/DEBUG_GCC49/ARM/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe/DEBUG/FvSimpleFileSystem.dll 0xBA844240 Loading driver at 0x000BA844000 EntryPoint=0x000BA844271 FvSimpleFileSystem.efi ASSERT /linaro/working/edk2.git/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c(410): fdt_check_header ((void*)(UINTN)FdtBlobBase) == 0 If I revert the patch from this email thread, then TC2 will boot to the BDS menu properly. Of course, there is then no way to boot a Linux kernel because there is no longer a mechanism to provide a device tree blob. Reverting this patch isn't straight-forward, of course. An additional patch/hack (attached) is then needed to revert further changes made to the .dsc and .inc files to add FdtPlatformDex.inf. This is all when working with the latest EDK2 upstream code, AFAICT, TC2 has been broken since mid-2014. [1] ArmPkg/ArmArchTimerLib: Remove non required [depex] and IoLib commit id ad91798676e8497b0631ff24d1bee031c0a38e9b On 25 February 2015 at 19:20, <oliviermartin(a)users.sourceforge.net> wrote: > Revision: 16933 > http://sourceforge.net/p/edk2/code/16933 > Author: oliviermartin > Date: 2015-02-25 19:20:57 +0000 (Wed, 25 Feb 2015) > Log Message: > ----------- > EmbeddedPkg : Add FdtPlatformDxe driver > > The FdtPlatformDxe driver installs the FDT of the platform it > is running on into the UEFI Configuration table at the end of > the DXE phase. > > Please refer to the README.txt file for a global overview of > the driver. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ronald Cron <Ronald.Cron(a)arm.com> > Reviewed-by: Olivier Martin <olivier.martin(a)arm.com> > > Modified Paths: > -------------- > trunk/edk2/EmbeddedPkg/EmbeddedPkg.dec > trunk/edk2/EmbeddedPkg/EmbeddedPkg.dsc > trunk/edk2/EmbeddedPkg/Include/Guid/Fdt.h > > Added Paths: > ----------- > trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/ > trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c > trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt > > Added: trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c > =================================================================== > --- trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c > (rev 0) > +++ trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.c 2015-02-25 > 19:20:57 UTC (rev 16933) > @@ -0,0 +1,742 @@ > +/** @file > + > + Copyright (c) 2015, ARM Ltd. All rights reserved. > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the > BSD License > + which accompanies this distribution. The full text of the license may > be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +**/ > +#include <Uefi.h> > + > +#include <Library/UefiLib.h> > +#include <Library/DebugLib.h> > +#include <Library/UefiBootServicesTableLib.h> > +#include <Library/UefiRuntimeServicesTableLib.h> > +#include <Library/PcdLib.h> > +#include <Library/DevicePathLib.h> > +#include <Library/MemoryAllocationLib.h> > + > +#include <Library/BdsLib.h> > + > +#include <Protocol/DevicePathFromText.h> > +#include <Protocol/DevicePath.h> > + > +#include <Guid/EventGroup.h> > +#include <Guid/Fdt.h> > + > +#include <libfdt.h> > + > +// > +// Internal types > +// > +STATIC VOID OnEndOfDxe ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ); > +STATIC EFI_STATUS RunFdtInstallation ( > + VOID > + ); > +STATIC EFI_STATUS InstallFdt ( > + IN CONST CHAR16* TextDevicePath > + ); > + > +/** > + Main entry point of the FDT platform driver. > + > + @param[in] ImageHandle The firmware allocated handle for the present > driver > + UEFI image. > + @param[in] *SystemTable A pointer to the EFI System table. > + > + @retval EFI_SUCCESS The driver was initialized. > + @retval EFI_OUT_OF_RESOURCES The "End of DXE" event could not be > allocated. > + > +**/ > +EFI_STATUS > +FdtPlatformEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + EFI_EVENT EndOfDxeEvent; > + > + // > + // Create an event belonging to the "gEfiEndOfDxeEventGroupGuid" group. > + // The "OnEndOfDxe()" function is declared as the call back function. > + // It will be called at the end of the DXE phase when an event of the > + // same group is signalled to inform about the end of the DXE phase. > + // > + Status = gBS->CreateEventEx ( > + EVT_NOTIFY_SIGNAL, > + TPL_CALLBACK, > + OnEndOfDxe, > + NULL, > + &gEfiEndOfDxeEventGroupGuid, > + &EndOfDxeEvent > + ); > + > + return Status; > +} > + > +/** > + Notification function of the event defined as belonging to the > + EFI_END_OF_DXE_EVENT_GROUP_GUID event group that was created in > + the entry point of the driver. > + > + This function is called when an event belonging to the > + EFI_END_OF_DXE_EVENT_GROUP_GUID event group is signalled. Such an > + event is signalled once at the end of the dispatching of all > + drivers (end of the so called DXE phase). > + > + @param[in] Event Event declared in the entry point of the driver > whose > + notification function is being invoked. > + @param[in] Context NULL > + > +**/ > +STATIC > +VOID > +OnEndOfDxe ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + RunFdtInstallation (); > + gBS->CloseEvent (Event); > +} > + > +/** > + Run the FDT installation process. > + > + Loop in priority order over the device paths from which the FDT has > + been asked to be retrieved for. For each device path, try to install > + the FDT. Stop as soon as an installation succeeds. > + > + @retval EFI_SUCCESS The FDT was installed. > + @retval EFI_NOT_FOUND Failed to locate a protocol or a file. > + @retval EFI_INVALID_PARAMETER Invalid device path. > + @retval EFI_UNSUPPORTED Device path not supported. > + @retval EFI_OUT_OF_RESOURCES An allocation failed. > + > +**/ > +STATIC > +EFI_STATUS > +RunFdtInstallation ( > + VOID > + ) > +{ > + EFI_STATUS Status; > + UINTN DataSize; > + VOID *Data; > + CHAR16 *TextDevicePathStart; > + CHAR16 *TextDevicePathSeparator; > + UINTN TextDevicePathLen; > + CHAR16 *TextDevicePath; > + > + // > + // For development purpose, if enabled through the > "PcdOverridePlatformFdt" > + // feature PCD, try first to install the FDT specified by the device > path in > + // text form stored in the "Fdt" UEFI variable. > + // > + if (FeaturePcdGet (PcdOverridePlatformFdt)) { > + Data = NULL; > + DataSize = 0; > + Status = gRT->GetVariable ( > + L"Fdt", > + &gFdtVariableGuid, > + NULL, > + &DataSize, > + Data > + ); > + > + // > + // Keep going only if the "Fdt" variable is defined. > + // > + > + if (Status == EFI_BUFFER_TOO_SMALL) { > + Data = AllocatePool (DataSize); > + if (Data == NULL) { > + Status = EFI_OUT_OF_RESOURCES; > + } else { > + Status = gRT->GetVariable ( > + L"Fdt", > + &gFdtVariableGuid, > + NULL, > + &DataSize, > + Data > + ); > + if (!EFI_ERROR (Status)) { > + Status = InstallFdt ((CHAR16*)Data); > + if (!EFI_ERROR (Status)) { > + DEBUG (( > + EFI_D_WARN, > + "Installation of the FDT using the device path <%s> > completed.\n", > + (CHAR16*)Data > + )); > + } > + } > + FreePool (Data); > + } > + > + if (EFI_ERROR (Status)) { > + DEBUG (( > + EFI_D_ERROR, > + "Installation of the FDT specified by the \"Fdt\" UEFI variable > failed - %r\n", > + Status > + )); > + } else { > + return Status; > + } > + } > + } > + > + // > + // Loop over the device path list provided by "PcdFdtDevicePaths". The > device > + // paths are in text form and separated by a semi-colon. > + // > + > + Status = EFI_SUCCESS; > + for (TextDevicePathStart = (CHAR16*)PcdGetPtr (PcdFdtDevicePaths); > + *TextDevicePathStart != L'\0' ; ) { > + TextDevicePathSeparator = StrStr (TextDevicePathStart, L";"); > + > + // > + // Last device path of the list > + // > + if (TextDevicePathSeparator == NULL) { > + TextDevicePath = TextDevicePathStart; > + } else { > + TextDevicePathLen = (UINTN)(TextDevicePathSeparator - > TextDevicePathStart); > + TextDevicePath = AllocateCopyPool ( > + (TextDevicePathLen + 1) * sizeof (CHAR16), > + TextDevicePathStart > + ); > + if (TextDevicePath == NULL) { > + Status = EFI_OUT_OF_RESOURCES; > + DEBUG ((EFI_D_ERROR, "Memory allocation error during FDT > installation process.\n")); > + break; > + } > + TextDevicePath[TextDevicePathLen] = L'\0'; > + } > + > + Status = InstallFdt (TextDevicePath); > + if (EFI_ERROR (Status)) { > + DEBUG ((EFI_D_WARN, "Installation of the FDT using the device path > <%s> failed - %r.\n", > + TextDevicePath, Status > + )); > + } else { > + DEBUG ((EFI_D_WARN, "Installation of the FDT using the device path > <%s> completed.\n", > + TextDevicePath > + )); > + } > + > + if (TextDevicePathSeparator == NULL) { > + break; > + } else { > + FreePool (TextDevicePath); > + if (!EFI_ERROR (Status)) { > + break; > + } > + TextDevicePathStart = TextDevicePathSeparator + 1; > + } > + } > + > + if (EFI_ERROR (Status)) { > + DEBUG ((EFI_D_ERROR, "Failed to install the FDT - %r.\n", Status)); > + } > + > + return Status; > +} > + > +/** > + Install the FDT specified by its device path in text form. > + > + @param[in] TextDevicePath Device path of the FDT to install in text > form > + > + @retval EFI_SUCCESS The FDT was installed. > + @retval EFI_NOT_FOUND Failed to locate a protocol or a file. > + @retval EFI_INVALID_PARAMETER Invalid device path. > + @retval EFI_UNSUPPORTED Device path not supported. > + @retval EFI_OUT_OF_RESOURCES An allocation failed. > +**/ > +STATIC > +EFI_STATUS > +InstallFdt ( > + IN CONST CHAR16* TextDevicePath > + ) > +{ > + EFI_STATUS Status; > + EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL *EfiDevicePathFromTextProtocol; > + EFI_DEVICE_PATH *DevicePath; > + EFI_PHYSICAL_ADDRESS FdtBlobBase; > + UINTN FdtBlobSize; > + UINTN NbPages; > + EFI_PHYSICAL_ADDRESS RsFdtBlobBase; > + > + Status = gBS->LocateProtocol ( > + &gEfiDevicePathFromTextProtocolGuid, > + NULL, > + (VOID **)&EfiDevicePathFromTextProtocol > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((EFI_D_ERROR, "InstallFdt() - Failed to locate > EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL protocol\n")); > + return Status; > + } > + > + DevicePath = > (EFI_DEVICE_PATH*)EfiDevicePathFromTextProtocol->ConvertTextToDevicePath > (TextDevicePath); > + if (DevicePath == NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + // > + // Load the FDT given its device path. > + // This operation may fail if the device path is not supported. > + // > + FdtBlobBase = 0; > + NbPages = 0; > + Status = BdsLoadImage (DevicePath, AllocateAnyPages, &FdtBlobBase, > &FdtBlobSize); > + if (EFI_ERROR (Status)) { > + goto Error; > + } > + > + // Check the FDT header is valid. We only make this check in DEBUG mode > in > + // case the FDT header change on production device and this ASSERT() > becomes > + // not valid. > + ASSERT (fdt_check_header ((VOID*)(UINTN)FdtBlobBase) == 0); > + > + // > + // Ensure the Size of the Device Tree is smaller than the size of the > read file > + // > + ASSERT ((UINTN)fdt_totalsize ((VOID*)(UINTN)FdtBlobBase) <= > FdtBlobSize); > + > + // > + // Store the FDT as Runtime Service Data to prevent the Kernel from > + // overwritting its data. > + // > + NbPages = EFI_SIZE_TO_PAGES (FdtBlobSize); > + Status = gBS->AllocatePages ( > + AllocateAnyPages, EfiRuntimeServicesData, > + NbPages, &RsFdtBlobBase > + ); > + if (EFI_ERROR (Status)) { > + goto Error; > + } > + CopyMem ( > + (VOID*)((UINTN)RsFdtBlobBase), > + (VOID*)((UINTN)FdtBlobBase), > + FdtBlobSize > + ); > + > + // > + // Install the FDT into the Configuration Table > + // > + Status = gBS->InstallConfigurationTable ( > + &gFdtTableGuid, > + (VOID*)((UINTN)RsFdtBlobBase) > + ); > + if (EFI_ERROR (Status)) { > + gBS->FreePages (RsFdtBlobBase, NbPages); > + } > + > +Error : > + > + if (FdtBlobBase != 0) { > + gBS->FreePages (FdtBlobBase, NbPages); > + } > + FreePool (DevicePath); > + > + return Status; > +} > + > +======= > + > +/** > + This is the shell command "setfdt" handler function. This function > handles > + the command when it is invoked in the shell. > + > + @param[in] This The instance of the > + EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL. > + @param[in] SystemTable The pointer to the UEFI system table. > + @param[in] ShellParameters The parameters associated with the command. > + @param[in] Shell The instance of the shell protocol used in > the > + context of processing this command. > + > + @return SHELL_SUCCESS The operation was successful. > + @return SHELL_ABORTED Operation aborted due to internal > error. > + @return SHELL_INVALID_PARAMETER The parameters of the command are not > valid. > + @return SHELL_INVALID_PARAMETER The EFI Shell file path is not valid. > + @return SHELL_NOT_FOUND Failed to locate a protocol or a file. > + @return SHELL_UNSUPPORTED Device path not supported. > + @return SHELL_OUT_OF_RESOURCES A memory allocation failed. > + @return SHELL_DEVICE_ERROR The "Fdt" variable could not be saved > due to a hardware failure. > + @return SHELL_ACCESS_DENIED The "Fdt" variable is read-only. > + @return SHELL_ACCESS_DENIED The "Fdt" variable cannot be deleted. > + @return SHELL_ACCESS_DENIED The "Fdt" variable could not be > written due to security violation. > + > +**/ > +STATIC > +SHELL_STATUS > +EFIAPI > +ShellDynCmdSetFdtHandler ( > + IN EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL *This, > + IN EFI_SYSTEM_TABLE *SystemTable, > + IN EFI_SHELL_PARAMETERS_PROTOCOL *ShellParameters, > + IN EFI_SHELL_PROTOCOL *Shell > + ) > +{ > + SHELL_STATUS ShellStatus; > + EFI_STATUS Status; > + LIST_ENTRY *ParamPackage; > + BOOLEAN FilePath; > + CONST CHAR16 *ValueStr; > + > + ShellStatus = SHELL_SUCCESS; > + ParamPackage = NULL; > + FilePath = FALSE; > + > + // > + // Install the Shell and Shell Parameters Protocols on the driver > + // image. This is necessary for the initialisation of the Shell > + // Library to succeed in the next step. > + // > + Status = gBS->InstallMultipleProtocolInterfaces ( > + &gImageHandle, > + &gEfiShellProtocolGuid, Shell, > + &gEfiShellParametersProtocolGuid, ShellParameters, > + NULL > + ); > + if (EFI_ERROR (Status)) { > + return SHELL_ABORTED; > + } > + > + // > + // Initialise the Shell Library as we are going to use it. > + // Assert that the return code is EFI_SUCCESS as it should. > + // To anticipate any change is the codes returned by > + // ShellInitialize(), leave in case of error. > + // > + Status = ShellInitialize (); > + if (EFI_ERROR (Status)) { > + ASSERT_EFI_ERROR (Status); > + return SHELL_ABORTED; > + } > + > + Status = ShellCommandLineParse (ParamList, &ParamPackage, NULL, TRUE); > + if (!EFI_ERROR (Status)) { > + switch (ShellCommandLineGetCount (ParamPackage)) { > + case 1: > + // > + // Case "setfdt -i" > + // > + if (!ShellCommandLineGetFlag (ParamPackage, L"-i")) { > + Status = EFI_INVALID_PARAMETER; > + } > + break; > + > + case 2: > + // > + // Case "setfdt file_path" or > + // "setfdt -i file_path" or > + // "setfdt file_path -i" > + // > + FilePath = TRUE; > + break; > + > + default: > + Status = EFI_INVALID_PARAMETER; > + } > + } > + if (EFI_ERROR (Status)) { > + ShellStatus = EfiCodeToShellCode (Status); > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_ERROR), > + mFdtPlatformDxeHiiHandle, > + Status > + ); > + goto Error; > + } > + > + // > + // Update the preferred device path for the FDT if asked for. > + // > + if (FilePath) { > + ValueStr = ShellCommandLineGetRawValue (ParamPackage, 1); > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_UPDATING), > + mFdtPlatformDxeHiiHandle > + ); > + ShellStatus = UpdateFdtTextDevicePath (Shell, ValueStr); > + if (ShellStatus != SHELL_SUCCESS) { > + goto Error; > + } > + } > + > + // > + // Run the FDT installation process if asked for. > + // > + if (ShellCommandLineGetFlag (ParamPackage, L"-i")) { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_INSTALLING), > + mFdtPlatformDxeHiiHandle > + ); > + Status = RunFdtInstallation (); > + ShellStatus = EfiCodeToShellCode (Status); > + if (!EFI_ERROR (Status)) { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_INSTALL_SUCCEEDED), > + mFdtPlatformDxeHiiHandle > + ); > + } else { > + if (Status == EFI_INVALID_PARAMETER) { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_INVALID_DEVICE_PATH), > + mFdtPlatformDxeHiiHandle > + ); > + } else { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_ERROR), > + mFdtPlatformDxeHiiHandle, > + Status > + ); > + } > + } > + } > + > +Error: > + > + gBS->UninstallMultipleProtocolInterfaces ( > + gImageHandle, > + &gEfiShellProtocolGuid, Shell, > + &gEfiShellParametersProtocolGuid, ShellParameters, > + NULL > + ); > + ShellCommandLineFreeVarList (ParamPackage); > + > + return ShellStatus; > +} > + > +/** > + This is the shell command "setfdt" help handler function. This > + function returns the formatted help for the "setfdt" command. > + The format matchs that in Appendix B of the revision 2.1 of the > + UEFI Shell Specification. > + > + @param[in] This The instance of the > EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL. > + @param[in] Language The pointer to the language string to use. > + > + @return CHAR16* Pool allocated help string, must be freed by caller. > +**/ > +STATIC > +CHAR16* > +EFIAPI > +ShellDynCmdSetFdtGetHelp ( > + IN EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL *This, > + IN CONST CHAR8 *Language > + ) > +{ > + // > + // This allocates memory. The caller has to free the allocated memory. > + // > + return HiiGetString ( > + mFdtPlatformDxeHiiHandle, > + STRING_TOKEN (STR_GET_HELP_SETFDT), > + Language > + ); > +} > + > +/** > + Update the text device path stored in the "Fdt" UEFI variable given > + an EFI Shell file path or a text device path. > + > + This function is a subroutine of the ShellDynCmdSetFdtHandler() function > + to make its code easier to read. > + > + @param[in] Shell The instance of the shell protocol used in > the > + context of processing the "setfdt" command. > + @param[in] FilePath EFI Shell path or the device path to the FDT > file. > + > + @return SHELL_SUCCESS The text device path was succesfully > updated. > + @return SHELL_INVALID_PARAMETER The Shell file path is not valid. > + @return SHELL_OUT_OF_RESOURCES A memory allocation failed. > + @return SHELL_DEVICE_ERROR The "Fdt" variable could not be saved > due to a hardware failure. > + @return SHELL_ACCESS_DENIED The "Fdt" variable is read-only. > + @return SHELL_ACCESS_DENIED The "Fdt" variable cannot be deleted. > + @return SHELL_ACCESS_DENIED The "Fdt" variable could not be > written due to security violation. > + @return SHELL_NOT_FOUND Device path to text protocol not > found. > + @return SHELL_ABORTED Operation aborted. > + > +**/ > +STATIC > +SHELL_STATUS > +UpdateFdtTextDevicePath ( > + IN EFI_SHELL_PROTOCOL *Shell, > + IN CONST CHAR16 *FilePath > + ) > +{ > + EFI_STATUS Status; > + EFI_DEVICE_PATH *DevicePath; > + EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *EfiDevicePathToTextProtocol; > + CHAR16 *TextDevicePath; > + CHAR16 *FdtVariableValue; > + EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL *EfiDevicePathFromTextProtocol; > + SHELL_STATUS ShellStatus; > + > + ASSERT (FilePath != NULL); > + TextDevicePath = NULL; > + FdtVariableValue = NULL; > + > + DevicePath = Shell->GetDevicePathFromFilePath (FilePath); > + if (DevicePath != NULL) { > + Status = gBS->LocateProtocol ( > + &gEfiDevicePathToTextProtocolGuid, > + NULL, > + (VOID **)&EfiDevicePathToTextProtocol > + ); > + if (EFI_ERROR (Status)) { > + goto Error; > + } > + > + TextDevicePath = EfiDevicePathToTextProtocol->ConvertDevicePathToText > ( > + DevicePath, > + FALSE, > + FALSE > + ); > + if (TextDevicePath == NULL) { > + Status = EFI_OUT_OF_RESOURCES; > + goto Error; > + } > + FdtVariableValue = TextDevicePath; > + } else { > + // > + // Try to convert back the EFI Device Path String into a EFI device > Path > + // to ensure the format is valid > + // > + Status = gBS->LocateProtocol ( > + &gEfiDevicePathFromTextProtocolGuid, > + NULL, > + (VOID **)&EfiDevicePathFromTextProtocol > + ); > + if (EFI_ERROR (Status)) { > + goto Error; > + } > + > + DevicePath = EfiDevicePathFromTextProtocol->ConvertTextToDevicePath ( > + FilePath > + ); > + if (DevicePath == NULL) { > + Status = EFI_INVALID_PARAMETER; > + goto Error; > + } > + FdtVariableValue = (CHAR16*)FilePath; > + } > + > + Status = gRT->SetVariable ( > + (CHAR16*)L"Fdt", > + &gFdtVariableGuid, > + EFI_VARIABLE_RUNTIME_ACCESS | > + EFI_VARIABLE_NON_VOLATILE | > + EFI_VARIABLE_BOOTSERVICE_ACCESS , > + StrSize (FdtVariableValue), > + FdtVariableValue > + ); > + > +Error: > + ShellStatus = EfiCodeToShellCode (Status); > + if (!EFI_ERROR (Status)) { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_UPDATE_SUCCEEDED), > + mFdtPlatformDxeHiiHandle, > + FdtVariableValue > + ); > + } else { > + if (Status == EFI_INVALID_PARAMETER) { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_INVALID_PATH), > + mFdtPlatformDxeHiiHandle, > + FilePath > + ); > + } else { > + ShellPrintHiiEx ( > + -1, -1, NULL, > + STRING_TOKEN (STR_SETFDT_ERROR), > + mFdtPlatformDxeHiiHandle, > + Status > + ); > + } > + } > + > + if (DevicePath != NULL) { > + FreePool (DevicePath); > + } > + if (TextDevicePath != NULL) { > + FreePool (TextDevicePath); > + } > + > + return ShellStatus; > +} > + > +/** > + Transcode one of the EFI return code used by the model into an EFI > Shell return code. > + > + @param[in] Status EFI return code. > + > + @return Transcoded EFI Shell return code. > + > +**/ > +STATIC > +SHELL_STATUS > +EfiCodeToShellCode ( > + IN EFI_STATUS Status > + ) > +{ > + SHELL_STATUS ShellStatus; > + > + switch (Status) { > + case EFI_SUCCESS : > + ShellStatus = SHELL_SUCCESS; > + break; > + > + case EFI_INVALID_PARAMETER : > + ShellStatus = SHELL_INVALID_PARAMETER; > + break; > + > + case EFI_UNSUPPORTED : > + ShellStatus = SHELL_UNSUPPORTED; > + break; > + > + case EFI_DEVICE_ERROR : > + ShellStatus = SHELL_DEVICE_ERROR; > + break; > + > + case EFI_WRITE_PROTECTED : > + case EFI_SECURITY_VIOLATION : > + ShellStatus = SHELL_ACCESS_DENIED; > + break; > + > + case EFI_OUT_OF_RESOURCES : > + ShellStatus = SHELL_OUT_OF_RESOURCES; > + break; > + > + case EFI_NOT_FOUND : > + ShellStatus = SHELL_NOT_FOUND; > + break; > + > + default : > + ShellStatus = SHELL_ABORTED; > + } > + > + return ShellStatus; > +} > +>>>>>>> 4ac4fed... EmbeddedPkg/FdtPlatformDxe: Fix typo issue > > Added: trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > =================================================================== > --- trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > (rev 0) > +++ trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > 2015-02-25 19:20:57 UTC (rev 16933) > @@ -0,0 +1,55 @@ > +#/** @file > +# > +# Copyright (c) 2015, ARM Ltd. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the > BSD License > +# which accompanies this distribution. The full text of the license may > be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010006 > + BASE_NAME = FdtPlatformDxe > + FILE_GUID = 6e9a4c69-57c6-4fcd-b083-4f2c3bdb6051 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 0.1 > + ENTRY_POINT = FdtPlatformEntryPoint > + > +[Sources.common] > + FdtPlatform.c > + > +[Packages] > + EmbeddedPkg/EmbeddedPkg.dec > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + UefiDriverEntryPoint > + BdsLib > + DxeServicesTableLib > + BaseMemoryLib > + DebugLib > + UefiBootServicesTableLib > + UefiRuntimeServicesTableLib > + > +[Protocols] > + gEfiDevicePathFromTextProtocolGuid > + > +[Guids] > + gEfiEndOfDxeEventGroupGuid > + gFdtTableGuid > + gFdtVariableGuid > + > +[FeaturePcd] > + gEmbeddedTokenSpaceGuid.PcdOverridePlatformFdt > + > +[Pcd] > + gEmbeddedTokenSpaceGuid.PcdFdtDevicePaths > + > +[Depex] > + TRUE > > Added: trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt > =================================================================== > --- trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt > (rev 0) > +++ trunk/edk2/EmbeddedPkg/Drivers/FdtPlatformDxe/README.txt 2015-02-25 > 19:20:57 UTC (rev 16933) > @@ -0,0 +1,50 @@ > +/** @file > + > + Copyright (c) 2015, ARM Ltd. All rights reserved. > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the > BSD License > + which accompanies this distribution. The full text of the license may > be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > + > +**/ > + > +The purpose of the FdtPlatformDxe UEFI driver is to install the Flat > Device > +Tree (FDT) of the platform the UEFI frimware is running on into the UEFI > +Configuration Table. The FDT is identified within the UEFI Configuration > +Table by the "gFdtTableGuid" GUID defined in EmbeddedPkg.dec. > + > +Once installed, an UEFI application or OS boot loader can get from the > UEFI > +Configuration Table the FDT of the platform from the "gFdtTableGuid" GUID. > + > +The installation is done after each boot at the end of the DXE phase, > +just before the BDS phase. It is done at the end of the DXE phase to be > sure > +that all drivers have been dispatched. That way, all UEFI protocols that > may > +be needed to retrieve the FDT can be made available. It is done before > the BDS > +phase to be able to provide the FDT during that phase. > + > +The present driver tries to retrieve the FDT from the device paths > defined in the > +"gEmbeddedTokenSpaceGuid.PcdFdtDevicePaths" PCD. The "PcdFdtDevicePaths" > PCD > +contains a list a device paths. The device paths are in the text form and > +separated by semi-colons. The present driver tries the device paths in > the order > +it finds them in the "PcdFdtDevicePaths" PCD as long as he did not install > +succesfully a FDT. > + > +The "PcdFdtDevicePaths" PCD is a dynamic PCD that can be modified during > the > +DXE phase. This allows for exemple to select the right FDT when a binary > is > +intended to run on several platforms and/or variants of a platform. > + > +If the driver manages to download a FDT from one of the device paths > mentioned > +above then it installs it in the UEFI Configuration table and the run > over the > +device paths is stopped. > + > +For development purposes only, if the feature PCD > "gEmbeddedTokenSpaceGuid. > +PcdOverridePlatformFdt" is equal to TRUE, then before to try to install > the > +FDT from the device paths listed in the "PcdFdtDevicePaths" PCD, the > present > +driver tries to install it using the device path defined by the UEFI > variable > +"Fdt". If the variable does not exist or the installation using the > device path > +defined by the UEFI variable fails then the installation proceeds as > described > +above. > > Modified: trunk/edk2/EmbeddedPkg/EmbeddedPkg.dec > =================================================================== > --- trunk/edk2/EmbeddedPkg/EmbeddedPkg.dec 2015-02-25 19:15:39 UTC > (rev 16932) > +++ trunk/edk2/EmbeddedPkg/EmbeddedPkg.dec 2015-02-25 19:20:57 UTC > (rev 16933) > @@ -52,6 +52,7 @@ > ## FDT Configuration Table > # Include/Guid/Fdt.h > gFdtTableGuid = { 0xb1b621d5, 0xf19c, 0x41a5, { 0x83, 0x0b, 0xd9, 0x15, > 0x2c, 0x69, 0xaa, 0xe0 } } > + gFdtVariableGuid = { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, > 0xc8, 0x4e, 0xfb, 0x3e, 0x57 } } > > [Protocols.common] > gHardwareInterruptProtocolGuid = { 0x2890B3EA, 0x053D, 0x1643, { 0xAD, > 0x0C, 0xD6, 0x48, 0x08, 0xDA, 0x3F, 0xF1 } } > @@ -79,6 +80,7 @@ > > gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|FALSE|BOOLEAN|0x0000001b > gEmbeddedTokenSpaceGuid.PcdCacheEnable|FALSE|BOOLEAN|0x00000042 > gEmbeddedTokenSpaceGuid.PcdGdbSerial|FALSE|BOOLEAN|0x00000053 > + gEmbeddedTokenSpaceGuid.PcdOverridePlatformFdt|TRUE|BOOLEAN|0x00000054 > > > [PcdsFixedAtBuild.common] > @@ -148,6 +150,7 @@ > > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootUsbProductId|0xbeef|UINT32|0x00000023 > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort|1234|UINT32|0x00000024 > > + > [PcdsFixedAtBuild.ARM] > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|32|UINT8|0x00000010 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00000011 > @@ -169,3 +172,6 @@ > [PcdsFixedAtBuild.X64] > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|52|UINT8|0x00000010 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011 > + > +[PcdsFixedAtBuild.common, PcdsDynamic.common] > + gEmbeddedTokenSpaceGuid.PcdFdtDevicePaths|L""|VOID*|0x00000055 > > Modified: trunk/edk2/EmbeddedPkg/EmbeddedPkg.dsc > =================================================================== > --- trunk/edk2/EmbeddedPkg/EmbeddedPkg.dsc 2015-02-25 19:15:39 UTC > (rev 16932) > +++ trunk/edk2/EmbeddedPkg/EmbeddedPkg.dsc 2015-02-25 19:20:57 UTC > (rev 16933) > @@ -264,8 +264,9 @@ > > EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf > > - # FDT Support > + # FDT installation > EmbeddedPkg/Library/FdtLoadLib/FdtLoadLib.inf > + EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf > > EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf > > EmbeddedPkg/Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsbDxe.inf > > Modified: trunk/edk2/EmbeddedPkg/Include/Guid/Fdt.h > =================================================================== > --- trunk/edk2/EmbeddedPkg/Include/Guid/Fdt.h 2015-02-25 19:15:39 UTC > (rev 16932) > +++ trunk/edk2/EmbeddedPkg/Include/Guid/Fdt.h 2015-02-25 19:20:57 UTC > (rev 16933) > @@ -12,12 +12,17 @@ > * > **/ > > -#ifndef __FDT_GUID_H__ > -#define __FDT_GUID_H__ > +#ifndef __FDT_H__ > +#define __FDT_H__ > > #define FDT_TABLE_GUID \ > { 0xb1b621d5, 0xf19c, 0x41a5, { 0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, > 0xaa, 0xe0 } } > > extern EFI_GUID gFdtTableGuid; > > -#endif /* __FDT_GUID_H__ */ > +#define FDT_VARIABLE_GUID \ > + { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, 0xc8, 0x4e, 0xfb, > 0x3e, 0x57 } } > + > +extern EFI_GUID gFdtVariableGuid; > + > +#endif /* __FDT_H__ */ > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, > sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for > all > things parallel software development, from weekly thought leadership blogs > to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > edk2-commits mailing list > edk2-commits(a)lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-commits >

10 years

Re: [Linaro-uefi] SF.net SVN: edk2:[15903] trunk/edk2/ArmPkg/Library/ArmArchTimerLib/ ArmArchTimerLib.inf

by Ryan Harkin

[+Olivier at his proper email address] [+ linaro-uefi mailing list] On 18 June 2015 at 18:46, Ryan Harkin <ryan.harkin(a)linaro.org> wrote: > TC2 no longer boots for me with this patch. If I revert it, it instead > crashes like this: > > add-symbol-file > /linaro/working/edk2.git/Build/ArmVExpress-CTA15-A7/DEBUG_GCC49/ARM/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe/DEBUG/FdtPlatformDxe.dll > 0xBA835240 > Loading driver at 0x000BA835000 EntryPoint=0x000BA835271 FdtPlatformDxe.efi > InstallFdt() - loaded FDT binary image seems corrupt > ASSERT /linaro/working/edk2.git/MdeModulePkg/Core/Dxe/Mem/Page.c(722): > NumberOfPages > > I'm building pure tianocore EDK2 from this commit: > > cc63add 2015-06-17 MdeModulePkg:System hangs in setup menu [Dandan Bi] > > ... with the patch from this thread reverted. > > > On 26 August 2014 at 11:16, <oliviermartin(a)users.sourceforge.net> wrote: > >> Revision: 15903 >> http://sourceforge.net/p/edk2/code/15903 >> Author: oliviermartin >> Date: 2014-08-26 10:16:16 +0000 (Tue, 26 Aug 2014) >> Log Message: >> ----------- >> ArmPkg/ArmArchTimerLib: Remove non required [depex] and IoLib >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Olivier Martin <olivier.martin(a)arm.com> >> >> Modified Paths: >> -------------- >> trunk/edk2/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >> >> Modified: trunk/edk2/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >> =================================================================== >> --- trunk/edk2/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >> 2014-08-26 10:15:21 UTC (rev 15902) >> +++ trunk/edk2/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >> 2014-08-26 10:16:16 UTC (rev 15903) >> @@ -1,6 +1,6 @@ >> #/** @file >> # >> -# Copyright (c) 2011-2012, ARM Limited. All rights reserved. >> +# Copyright (c) 2011 - 2014, ARM Limited. All rights reserved. >> # This program and the accompanying materials >> # are licensed and made available under the terms and conditions of the >> BSD License >> # which accompanies this distribution. The full text of the license >> may be found at >> @@ -28,19 +28,10 @@ >> EmbeddedPkg/EmbeddedPkg.dec >> ArmPkg/ArmPkg.dec >> >> - >> [LibraryClasses] >> DebugLib >> - IoLib >> ArmLib >> BaseLib >> >> -[Protocols] >> - >> -[Guids] >> - >> [Pcd] >> gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz >> - >> -[Depex] >> - gEfiCpuArchProtocolGuid >> >> This was sent by the SourceForge.net collaborative development platform, >> the world's largest Open Source development site. >> >> >> >> ------------------------------------------------------------------------------ >> Slashdot TV. >> Video for Nerds. Stuff that matters. >> http://tv.slashdot.org/ >> _______________________________________________ >> edk2-commits mailing list >> edk2-commits(a)lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-commits >> > >

10 years

[question] about JTAG debugger

by Haojian Zhuang

Hi all, I'm looking for a JTAG debugger that working in native linux environment. Do you know which one could support source code debugging on both Arm Trust Firmware and UEFI? Best Regards Haojian

10 years

[question] whether setting initrd support in boot args

by Haojian Zhuang

Hi Fathi, As we discussed yesterday, you mentioned that both "FDT support" and "Initrd support" should not be included in default boot args. But the problem is at here. https://github.com/96boards/bugs/issues/40 Fathi & Leif, Since PcdDefaultBootType is set to 0 by default, the kernel image is recognized as an EFI application. So we can't set any FDT path and Initrd path when it creates the default boot entry in UEFI. And we also can't set them even when we create a new boot entry from the boot image. We have to specify them in boot args. So I want to know what's the expected behavior in UEFI. Do we need to enhance the Bds to find FDT path & Initrd path even the kernel is recognized as an EFI application? Best Regards Haojian

10 years

[PATCH v2 0/2] Platforms/ARM: update gtdt.asl for VExpress

by fu.wei＠linaro.org

From: Fu Wei <fu.wei(a)linaro.org> This patchset update gtdt.asl for VExpress/AcpiTables/rtsm_ve-aemv8a (1)Fix "Platform Timer Offset" value bug (2)Add Memory-mapped GT and SBSA Generic Watchdog timer info base on Foundation Model Changelog: v2: Add "ontributed-under: TianoCore Contribution Agreement 1.0" for all patch Add an explanation for the fix of "Platform Timer Offset" value bug in the commit message. v1: The first version upstream patchset to linaro mailing listf for OpenPlatformPkg Fu Wei (2): Platforms/ARM: Fix "Platform Timer Offset" value bug in gtdt.asl Platforms/ARM: update gtdt.asl for VExpress .../VExpress/AcpiTables/rtsm_ve-aemv8a/gtdt.asl | 67 +++++++++++++++++----- 1 file changed, 53 insertions(+), 14 deletions(-) -- 1.9.1

10 years

[RFC 0/4] New terminal type for Linux

by Roy Franz

This patchset is a follow on to my previous backspace patchse, and adds a new terminal type "LinuxTerm" (for lack of a better name) that better handles the typical Linux terminal (xterm/rxvt/gnome terminal/etc.) These often treat backspace/delete differently than the existing EDK2 terminal types expect, particularly in emulated environments where the emulated serial port is connected to a graphical terminal rather than a serial console. For a description of how Debian has dealt with the terminal backspace/delete/^H mess, see the "Keyboard configuration" section of: https://www.debian.org/doc/debian-policy/ch-opersys.html#s9.8">KeyboardConfiguration I do not think that all Linux distributions agree on all the details, so my goal is to have a terminal defition that mostly works in many configurations. Backspace being broken in these environments is the primary motivation for this, but this terminal type could be exentend to better support the typical graphical terminal now in use. This terminal type may be of use in BSD environments as well, so I'm open to more generic name suggestions. I deliberately avoided calling it "xterm", as my intention is to try to work with multiple terminal types to the degree possible. Roy Franz (4): Add "LinuxTerm" terminal type to TerminalDxe Treat ASCII 0x7F as backspace for LinuxTerm terminal accept [3~ as delete for LinuxTerm terminals Change QEMU terminal type to LinuxTerm .../ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 4 +- BaseTools/Source/C/Include/Guid/PcAnsi.h | 6 +++ .../Foundation/Efi/Guid/PcAnsi/PcAnsi.c | 2 + .../Foundation/Efi/Guid/PcAnsi/PcAnsi.h | 6 +++ .../Universal/BdsDxe/BootMaint/BootMaint.h | 2 +- .../Universal/BdsDxe/BootMaint/Data.c | 5 ++- .../Universal/Console/TerminalDxe/Terminal.c | 44 ++++++++++++++++---- .../Universal/Console/TerminalDxe/Terminal.h | 2 + .../Universal/Console/TerminalDxe/TerminalConIn.c | 47 ++++++++++++++++++++-- .../Universal/Console/TerminalDxe/TerminalConOut.c | 2 + .../Universal/Console/TerminalDxe/TerminalDxe.inf | 1 + MdePkg/Include/Guid/PcAnsi.h | 6 +++ MdePkg/Include/Protocol/DevicePath.h | 1 + .../Library/UefiDevicePathLib/DevicePathFromText.c | 27 +++++++++++++ .../Library/UefiDevicePathLib/DevicePathToText.c | 3 ++ .../UefiDevicePathLib/UefiDevicePathLib.inf | 2 + ...UefiDevicePathLibOptionalDevicePathProtocol.inf | 4 +- MdePkg/MdePkg.dec | 3 ++ .../UefiHandleParsingLib/UefiHandleParsingLib.c | 1 + .../UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 + 20 files changed, 153 insertions(+), 16 deletions(-) -- 1.9.1

10 years

[RFC PATCH] Avoid all Linux /dev/mem accesses when -c is specified

by Roy Franz

Don't try to read the RSDP structure or RSDT/XSDT tables from memory with the -c option. These are now provided as files in /sysfs, and this allows acpidump to function when /dev/mem is not available, which will be the case for Aarch64 servers. Signed-off-by: Roy Franz <roy.franz(a)linaro.org> --- Graeme - all this is tested with your patch, which looks good. It takes care of what acpidump needs from sysfs. Al - this fixes acpidump. Are there other utilities that I need to look at within acpica-tools? This produces almost the same output with/without the "-c" option, with the /sysfs files being used with "-c", with the following differences: * Table address are 0x0 with -c, since we don't get them from the sysfs files * the tables are listed in a different order. I have verified with strace that no /dev/mem accesses are made with "-c". An issue that this patch doesn't address, is what should be the default, and what should be done if /dev/mem is missing, or there but not readable. source/os_specific/service_layers/oslinuxtbl.c | 87 +++++++++++++------------- 1 file changed, 43 insertions(+), 44 deletions(-) diff --git a/source/os_specific/service_layers/oslinuxtbl.c b/source/os_specific/service_layers/oslinuxtbl.c index e090a3c..95cc674 100644 --- a/source/os_specific/service_layers/oslinuxtbl.c +++ b/source/os_specific/service_layers/oslinuxtbl.c @@ -686,70 +686,69 @@ OslTableInitialize ( return (AE_OK); } + if (!Gbl_DumpCustomizedTables) + { /* Get RSDP from memory */ - Status = OslLoadRsdp (); - if (ACPI_FAILURE (Status)) - { - return (Status); - } + Status = OslLoadRsdp (); + if (ACPI_FAILURE (Status)) + { + return (Status); + } - /* Get XSDT from memory */ + /* Get XSDT from memory */ - if (Gbl_Rsdp.Revision && !Gbl_DoNotDumpXsdt) - { - if (Gbl_Xsdt) + if (Gbl_Rsdp.Revision && !Gbl_DoNotDumpXsdt) { - free (Gbl_Xsdt); - Gbl_Xsdt = NULL; + if (Gbl_Xsdt) + { + free (Gbl_Xsdt); + Gbl_Xsdt = NULL; + } + + Gbl_Revision = 2; + Status = OslGetBiosTable (ACPI_SIG_XSDT, 0, + ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Xsdt), &Address); + if (ACPI_FAILURE (Status)) + { + return (Status); + } } - Gbl_Revision = 2; - Status = OslGetBiosTable (ACPI_SIG_XSDT, 0, - ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Xsdt), &Address); - if (ACPI_FAILURE (Status)) + /* Get RSDT from memory */ + + if (Gbl_Rsdp.RsdtPhysicalAddress) { - return (Status); + if (Gbl_Rsdt) + { + free (Gbl_Rsdt); + Gbl_Rsdt = NULL; + } + + Status = OslGetBiosTable (ACPI_SIG_RSDT, 0, + ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Rsdt), &Address); + if (ACPI_FAILURE (Status)) + { + return (Status); + } } - } - /* Get RSDT from memory */ + /* Get FADT from memory */ - if (Gbl_Rsdp.RsdtPhysicalAddress) - { - if (Gbl_Rsdt) + if (Gbl_Fadt) { - free (Gbl_Rsdt); - Gbl_Rsdt = NULL; + free (Gbl_Fadt); + Gbl_Fadt = NULL; } - Status = OslGetBiosTable (ACPI_SIG_RSDT, 0, - ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Rsdt), &Address); + Status = OslGetBiosTable (ACPI_SIG_FADT, 0, + ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Fadt), &Gbl_FadtAddress); if (ACPI_FAILURE (Status)) { return (Status); } - } - /* Get FADT from memory */ - - if (Gbl_Fadt) - { - free (Gbl_Fadt); - Gbl_Fadt = NULL; - } - - Status = OslGetBiosTable (ACPI_SIG_FADT, 0, - ACPI_CAST_PTR (ACPI_TABLE_HEADER *, &Gbl_Fadt), &Gbl_FadtAddress); - if (ACPI_FAILURE (Status)) - { - return (Status); - } - - if (!Gbl_DumpCustomizedTables) - { /* Add mandatory tables to global table list first */ - Status = OslAddTableToList (ACPI_RSDP_NAME, 0); if (ACPI_FAILURE (Status)) { -- 1.9.1

10 years

← Newer
1
...
56
57
58
59
60
61
62
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi