On 8/23/2018 2:48 AM, Leif Lindholm wrote:
So, on the whole, I am really not happy for any of these commands to go into 18.08. I understand they may be handy for development, but I do not understand why they make sense to upstream.
As Oem Shell commands is useless for ERP, I will drop this patch and on-osi related components.
On Tue, Aug 14, 2018 at 04:09:02PM +0800, Ming Huang wrote:
Add Hisilicon Oem Shell libraries for some commands,such as biosupdate, getmac, setmac, provision, acpistartos, brdinfo, sfpinfo.
biosupdate example: ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1 biosupdate serverIp -u user -p password -f D06.fd -m master
acpistartos example: ifconfig -s eth2 static 192.168.2.69 255.255.255.0 192.168.2.1 provision serverIp -u user -p password -f os\Image -a 0x80000 2 provision serverIp -u user -p password -f os\minifs.cpio.gz -a 0x07000000 2 acpistartos
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ming.huang@linaro.org
Silicon/Hisilicon/HisiPkg.dec | 4 ++++ Platform/Hisilicon/D06/D06.dsc | 2 ++ 2 files changed, 6 insertions(+)
diff --git a/Silicon/Hisilicon/HisiPkg.dec b/Silicon/Hisilicon/HisiPkg.dec index 858b840a57..010d501914 100644 --- a/Silicon/Hisilicon/HisiPkg.dec +++ b/Silicon/Hisilicon/HisiPkg.dec @@ -39,6 +39,7 @@ gPlatformSasProtocolGuid = {0x40e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x5d}} gHisiPlatformSasProtocolGuid = {0x20e9829f, 0x3a2c, 0x479a, {0x9a, 0x93, 0x45, 0x7d, 0x13, 0x50, 0x96, 0x6d}} gHisiSnpPlatformProtocolGuid = {0x81321f27, 0xff58, 0x4a1d, {0x99, 0x97, 0xd, 0xcc, 0xfa, 0x82, 0xf4, 0x6f}}
- gOemNicProtocolGuid = {0xb5903955, 0x31e9, 0x4aaf, {0xb2, 0x83, 0x7, 0x9f, 0x3c, 0xc4, 0x71, 0x66}}
[Guids] gHisiTokenSpaceGuid = {0xc8bc553e, 0x12bf, 0x11e6, {0x97, 0x4f, 0x87, 0xf7, 0x7c, 0xfd, 0x52, 0x1d}} @@ -49,6 +50,8 @@ gHisiOemVariableGuid = {0xac62b9a5, 0x9939, 0x41d3, {0xff, 0x5c, 0xc5, 0x80, 0x32, 0x7d, 0x9b, 0x29}} gOemBootVariableGuid = {0xb7784577, 0x5aaf, 0x4557, {0xa1, 0x99, 0xd4, 0xa4, 0x2f, 0x45, 0x06, 0xf8}} gEfiHisiSocControllerGuid = {0xee369cc3, 0xa743, 0x5382, {0x75, 0x64, 0x53, 0xe4, 0x31, 0x19, 0x38, 0x35}}
- HisiShellSampleHiiGuid = { 0x43859314, 0x82c1, 0x4592, { 0x8f, 0xf7, 0xc1, 0xbd, 0xf3, 0xb2, 0x0e, 0xd5 }}
- HisiPlatformShellSampleHiiGuid = { 0x7924a5de, 0xc600, 0x40d5, { 0x91, 0x10, 0xf9, 0xc3, 0xe7, 0x25, 0x4d, 0x33 }}
Why do we need all these different GUIDs?
Also, why "Sample"?
/ Leif
[LibraryClasses] PlatformSysCtrlLib|Include/Library/PlatformSysCtrlLib.h @@ -101,6 +104,7 @@ gHisiTokenSpaceGuid.PcdSlotPerChannelNum|0x0|UINT32|0x40000004 gHisiTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x30006554
- gHisiTokenSpaceGuid.PcdStartOsParameter|L""|VOID*|0x5000000
#FDT File Address gHisiTokenSpaceGuid.FdtFileAddress|0x0|UINT64|0x40000005 diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc index 053ea894d5..544039e450 100644 --- a/Platform/Hisilicon/D06/D06.dsc +++ b/Platform/Hisilicon/D06/D06.dsc @@ -473,6 +473,8 @@ !if $(INCLUDE_DP) == TRUE NULL|ShellPkg/Library/UefiDpLib/UefiDpLib.inf !endif #$(INCLUDE_DP)
NULL|Silicon/Hisilicon/Library/HisiShellCmdLib/HisiShellCmdLib.infNULL|Silicon/Hisilicon/Hi1620/Library/HisiD06ShellCmdLib/HisiD06ShellCmdLib.inf<PcdsFixedAtBuild> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF -- 2.17.0