On 12 October 2016 at 09:34, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 12 October 2016 at 08:47, Ryan Harkin ryan.harkin@linaro.org wrote:
On 1 September 2016 at 18:12, Evan Lloyd Evan.Lloyd@arm.com wrote:
Hi Ard. Thank you very much for that astonishingly prompt and effective reaction to our problem. We'll get on with using it to implement our fixes, but in our more mortal timescale.
Regards, Evan
-----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: 01 September 2016 17:22 To: linaro-uefi@lists.linaro.org; ryan.harkin@linaro.org; Evan Lloyd; leif.lindholm@linaro.org; Charles Garcia-Tobin Cc: ard.biesheuvel@linaro.org Subject: [PATCH 0/3] ArmPkg: add support for configuring interrupt types
This is just a bunch of boilerplate code that extends the protocol HardwareInterrupt to HardwareInterrupt2, and adds some hooks that allow protocol clients to configure the interrupt type.
Patch #1 and patch #3 are complete afaict. Patch #2 needs to actual GIC manipulation code to be inserted, but I am sure someone else will be able to do this much more quickly.
Ard Biesheuvel (3): EmbeddedPkg: introduce HardwareInterrupt2 protocol ArmPkg/ArmGicDxe: expose HardwareInterrupt2 protocol ArmPkg/GenericWatchdogDxe: use HardwareInterrupt2 protocol to set interrupt type
ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 4 +- ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 2 + ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 + ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 37 +++- ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 37 +++- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 26 +-- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 4 +- EmbeddedPkg/EmbeddedPkg.dec | 1 + EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 181 ++++++++++++++++++++ 9 files changed, 278 insertions(+), 15 deletions(-) create mode 100644 EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h
I'm not sure if this patchset is going anywhere, but I tested it anyway and it works fine on Juno R0/1/2, TC2 and FVP Foundation and AEMv8 models.
Tested-by: Ryan Harkin ryan.harkin@linaro.org
Thanks for this, but given that this code is not wired up in any platform, I would be very surprised if it affected either of these platforms at build time or at runtime.
Of course. But most important to me: it didn't break anything! :-)
Are you waiting for Evan to come up with a user before pushing it out?