On 3 February 2016 at 09:18, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 3 February 2016 at 10:11, Ryan Harkin ryan.harkin@linaro.org wrote:
On 3 February 2016 at 08:33, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 2 February 2016 at 20:15, Ryan Harkin ryan.harkin@linaro.org wrote:
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf index 466b399..76c9249 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -164,7 +164,7 @@ FvNameGuid = 73dcb643-3862-4904-9076-a94af1890243 # # UEFI application #
- INF ShellBinPkg/UefiShell/UefiShell.inf
- INF ShellPkg/Application/Shell/Shell.inf
Should this patch (and the next one) perhaps be reordered against the patch that adds ShellPkg/Application/Shell/Shell.inf to the shared .dsc.inc?
Gah! Yes! I reordered it before posting to keep all the TC2 stuff together, forgetting about the change in the .dsc.inc file.
I guess I should split the .dsc.inc file change out from the FVP patch also?
I wouldn't mind terribly if you fold all 3 patches into one, tbh
Fair point; I guess they are all part of one 'thing' and shortens the series too. I've just done that locally and re-pushed my branch:
https://git.linaro.org/landing-teams/working/arm/OpenPlatformPkg.git https://git.linaro.org/landing-teams/working/arm/OpenPlatformPkg.git/commitd...