On Wed, Aug 08, 2018 at 08:22:27PM +0800, Ming wrote:
在 8/3/2018 6:37 PM, Leif Lindholm 写道:
On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote:
From: Sun Yuanchen sunyuanchen@huawei.com
ARM_ACPI_HEADER is used by a unify module in other Pkg,
What other Pkg?
HwPkg
Then please say so in the commit message.
so move some macro to PlatformArch.h for unify D0x.
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sun Yuanchen sunyuanchen@huawei.com Signed-off-by: Ming Huang ming.huang@linaro.org Signed-off-by: Heyi Guo heyi.guo@linaro.org
On the whole, I think this should be implemented for 1610/1616 separately, and then introduced in the first version of the 1620 header.
do it in v2.
Thanks.
diff --git a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h index f2e931f30b..03e96cfd31 100644 --- a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h +++ b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h @@ -37,5 +37,29 @@ #define S1_BASE 0x40000000000
+// +// ACPI table information used to initialize tables. +// +#define EFI_ACPI_ARM_OEM_ID 'H','I','S','I',' ',' ' // OEMID 6 bytes long +#define EFI_ACPI_ARM_OEM_TABLE_ID SIGNATURE_64 ('H','I','P','0','6',' ',' ',' ') // OEM table id 8 bytes long +#define EFI_ACPI_ARM_OEM_REVISION 0x00000000 +#define EFI_ACPI_ARM_CREATOR_ID SIGNATURE_32 ('I','N','T','L')
I realise this is just moving, but ... why are we claiming that Intel is the creator of these tables?
I don't know the reason. I think this is a history mistake.
Agreed. On the reviewer side also :)
CREATEOR_ID should be change to 'HISI' for 1620?
Yes please, I think that would make more sense.
It may be worth changing for 1610/1616 as well, but you need to discuss that internally. The code has had that value this long, so no need to resolve for the Linaro 18.08 release.
/ Leif