11 Jan
2017
11 Jan
'17
3:13 p.m.
On Wed, Jan 11, 2017 at 02:02:50PM +0100, Marcin Wojtas wrote:
// +// Device global index +// +STATIC UINT8 XenonIdx;
+// +// Tables with used Xenon instances and their configuration +// +STATIC UINT8 * CONST XenonDevEnabled = FixedPcdGetPtr (PcdPciESdhci); +STATIC UINT8 * CONST Xenon1v8Enabled = FixedPcdGetPtr (PcdXenon1v8Enable);
Actually, I missed these (they stick out more when subsequent patches add additional ones).
This is not a good way to do this. Map these into a local struct, and call a function initialising the struct from InitializeSdMmcPciHcDxe().
Ok. When initializing fields of the structure, do you suggest to use FixedPcdGetPtr or PcdGetPtr?
It's still a fixed PCD, right?
/ Leif