On 21 January 2016 at 08:07, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 18 January 2016 at 18:50, Ryan Harkin ryan.harkin@linaro.org wrote:
GICv3 with v2 legacy support was removed, but this patch adds it back in conditionally.
The default continues to use GICv3 natively unless specifically requested at build time by defining "ARM_FVP_GICV3_WITH_V2_LEGACY".
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index b14aeb0..194133a 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -77,6 +77,14 @@ # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
+!ifdef ARM_FVP_GICV3_WITH_V2_LEGACY
- # Force the UEFI GIC driver to use GICv2 legacy mode. To use
- # GICv3 without GICv2 legacy in UEFI, the ARM Trusted Firmware needs
- # to configure the Non-Secure interrupts in the GIC Redistributors
- # which is not supported at the moment.
The patches all look fine to me, but could we get rid of this comment? If this was ever true, the main reason it did not work before was a bug in the driver on the EDK2 side.
Sure, I'll remove it.
You're right that it's no longer true, but it used to be. That's the reason why I'm stuck in the dark ages using GICv2 legacy support.
Thanks, Ard.
- gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|TRUE
+!endif
[PcdsFixedAtBuild.common] gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Fixed Virtual Platform" gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"ARM-FVP" -- 2.1.4