Hi Jan,
On 18 March 2016 at 16:24, Jan Beulich JBeulich@suse.com wrote:
On 18.03.16 at 08:41, fu.wei@linaro.org wrote:
--- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -163,6 +163,36 @@ static void __init process_memory_node(const void *fdt, int node, } }
+static bool __init check_xsm_signature(const void *fdt, int node,
const char *name,u32 address_cells, u32 size_cells)+{
- uint32_t selinux_magic = 0xf97cff8c;
So this would be the 3rd instance of this literal number in the source base. I would have wanted to suggest using one of the two constants we already have, but I don't know which one to pick.
Daniel - why do we have both XSM_MAGIC and FLASK_MAGIC?
Ah, Sorry for that , I didn't know we already have these definition.
OK, I think we should use XSM_MAGIC, and I think FLASK_MAGIC should be "XenFlask". Please correct me if I misunderstand something.
So maybe I should do :
uint32_t xen_magic = XEN_MAGIC;
Jan