Re: [Linaro-uefi] [PATCH v2 6/6] Drivers/Net/MarvellYukon: Set Dual Address Cycle Attribute

On Thu, Aug 25, 2016 at 06:39:45PM -0400, Alan Ott wrote:

The Dual Address Cycle Attribute is necessary for bus mastering PCI devices which are capable of generating 64-bit addresses. See the "Driver Writer's Guide for UEFI 2.3.1" version 1.01, section 18.3.2.

No contributed-under or signed-off-by. I can add that on commit, but I'd need you to confirm that was your intent.

The fix is clearly correct.

While waiting for tested-bys on 3-5, I'd be happy to merge this one out of order, unless you'd like to wait.

Thanks,

Leif

---

Drivers/Net/MarvellYukonDxe/if_msk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Drivers/Net/MarvellYukonDxe/if_msk.c b/Drivers/Net/MarvellYukonDxe/if_msk.c index 3cab084..c05e51e 100644 --- a/Drivers/Net/MarvellYukonDxe/if_msk.c +++ b/Drivers/Net/MarvellYukonDxe/if_msk.c @@ -1160,7 +1160,7 @@ mskc_attach ( Status = mPciIo->Attributes ( mPciIo, EfiPciIoAttributeOperationEnable,

•      Supports,
  

•      Supports | EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE,
       NULL
       );
  

  }

-- 2.5.0