Sorry for reviving an old patch, but I'm just starting to go through my queue of patches I was meant to review...
On 9 March 2016 at 16:35, evan.lloyd@arm.com wrote:
From: Sami Mujawar sami.mujawar@arm.com
This patch enables the Graphics Output Protocol using HDLCD on the Juno platform.
Unfortunately, I don't think the HDLCD driver that this uses was ever submitted upstream. I think it only lived in an ARM tree. So this patch doesn't build.
If you want HDLCD to be live on Juno upstream, you'll have to also submit the HDLCD library too.
But.... I'd like to see HDLCD as an optional component, defaulting to not be included.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alexei Fedorov alexei.fedorov@arm.com Signed-off-by: Girish Pathak girish.pathak@arm.com Signed-off-by: Sami Mujawar sami.mujawar@arm.com Signed-off-by: Evan Lloyd evan.lloyd@arm.com
Platforms/ARM/Juno/ArmJuno.dsc | 12 +++++++++++- Platforms/ARM/Juno/ArmJuno.fdf | 5 ++++- 2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index 02472ce..d099d86 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2015, ARM Limited. All rights reserved. +# Copyright (c) 2013-2016, ARM Limited. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -50,6 +50,8 @@ # USB Requirements UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
- LcdPlatformLib|ArmPlatformPkg/ArmJunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf
[LibraryClasses.ARM] ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
@@ -118,6 +120,9 @@ # ARM PrimeCell #
- ## HdLcd
- gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x7FF60000
- ## PL011 - Serial Terminal gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x7FF80000 gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
@@ -248,6 +253,11 @@ ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
#
- # Graphic Output Protocol
- #
- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
- # # Semi-hosting filesystem # ArmPkg/Filesystem/SemihostFs/SemihostFs.inf
diff --git a/Platforms/ARM/Juno/ArmJuno.fdf b/Platforms/ARM/Juno/ArmJuno.fdf index e686a6d..2ca20b8 100644 --- a/Platforms/ARM/Juno/ArmJuno.fdf +++ b/Platforms/ARM/Juno/ArmJuno.fdf @@ -1,5 +1,5 @@ # -# Copyright (c) 2013-2015, ARM Limited. All rights reserved. +# Copyright (c) 2013-2016, ARM Limited. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -135,6 +135,9 @@ FvNameGuid = B73FE497-B92E-416e-8326-45AD0D270092 # Versatile Express FileSystem INF ArmPlatformPkg/FileSystem/BootMonFs/BootMonFs.inf
- # Graphic Output Protocol
- INF ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcdGraphicsOutputDxe.inf
- # # FAT filesystem + GPT/MBR partitioning #
-- 2.7.0