Hi Leif,
Thanks for your review comments. Please see my replies inline.
From: Leif Lindholm [mailto:leif.lindholm@linaro.org] Sent: Tuesday, October 18, 2016 9:02 PM
On Tue, Oct 18, 2016 at 10:15:41AM +0100, Ard Biesheuvel wrote:
diff --git a/Platforms/Nxp/LS1043aRdb/Library/LS1043aRdbLib/LS1043aRdbLib.inf b/Platforms/Nxp/LS1043aRdb/Library/LS1043aRdbLib/LS1043aRdbLib.inf new file mode 100644 index 0000000..e09d940 --- /dev/null +++
b/Platforms/Nxp/LS1043aRdb/Library/LS1043aRdbLib/LS1043aRdbLib.i
+++ nf @@ -0,0 +1,56 @@ +#/* @file +# Copyright (c) 2011-2013, ARM Limited. All rights reserved. +# Copyright (c) 2016, Freescale Semiconductor, Inc. All rights
reserved.
+# +# This program and the accompanying materials # are licensed and +made available under the terms and conditions of the BSD License # +which accompanies this distribution. The full text of the license +may be found at # http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" +BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,
EITHER EXPRESS OR IMPLIED.
+# +#*/
+[Defines]
- INF_VERSION = 0x00010005
- BASE_NAME = LS1043aRdbLib
- FILE_GUID = 736343a0-1d96-11e0-aaaa-
0002a5d5c51b
Please use a fresh GUID here
For example using https://www.guidgenerator.com/online-guid-generator.aspx
It's important to use a generator that follows rfc 4122 (with the tweaks that make them GUIDs rather then UUIDs) in order to maintain the statistical uniqueness.
All kinds of things can go horribly wrong if GUIDs clash, whether it be in .inf, .dec or .c/.h files...
Regards,
Understood. Thanks for the pointer. Will change this and other occurrences in v2.
Regards, Bhupesh